[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #12584: check for duplicate msg about rob taskGroup

[GitBox <gi...@apache.org>]

caishunfeng commented on code in PR #12584:
URL: https://github.com/apache/dolphinscheduler/pull/12584#discussion_r1007883331


##########
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java:
##########
@@ -2488,6 +2488,11 @@ public boolean robTaskGroupResource(TaskGroupQueue taskGroupQueue) {
             this.taskGroupQueueMapper.updateById(taskGroupQueue);
             this.taskGroupQueueMapper.updateInQueue(Flag.NO.getCode(), taskGroupQueue.getId());
             return true;
+        }else if (taskGroupQueueMapper.selectCountByTaskIdAndStatus(taskGroupQueue.getId(),

Review Comment:
   please check the code style, see https://dolphinscheduler.apache.org/en-us/docs/dev/user_doc/contribute/development-environment-setup.html



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org