You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pluto-dev@portals.apache.org by "Elliot Metsger (JIRA)" <ji...@apache.org> on 2007/03/02 07:14:50 UTC
[jira] Commented: (PLUTO-319) checkContextServerInfo test on Misc
Test page of Testsuite fails
[ https://issues.apache.org/jira/browse/PLUTO-319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477197 ]
Elliot Metsger commented on PLUTO-319:
--------------------------------------
I think this is because in the root pom.xml there is a property:
<pluto.container.version.minor>1.0-SNAPSHOT</pluto.container.version.minor>
I forgot to update that property. It is hard to automate the updating of that value because it is a "minor" version number. There there isn't a POM expression that we can use (that I know of) to get access to only the minor portion of the version.
> checkContextServerInfo test on Misc Test page of Testsuite fails
> ----------------------------------------------------------------
>
> Key: PLUTO-319
> URL: https://issues.apache.org/jira/browse/PLUTO-319
> Project: Pluto
> Issue Type: Bug
> Components: portlets-testsuite
> Affects Versions: 1.1.0
> Reporter: Craig Doremus
> Priority: Minor
> Fix For: 1.1.1
>
>
> The checkContextServerInfo test on the Misc Test page of the Testsuite fails. This is currently the only Testsuite test that fails on Pluto 1.1.0 GA.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (PLUTO-319) checkContextServerInfo test on
Misc Test page of Testsuite fails
Posted by Craig Doremus <cd...@apache.org>.
I'm all for removing a minor version check, but I still think we need a
version check in the testsuite. It's important to ensure that the portal
version is correct so that bug reports in Jira can be attributed to the
correct version. I know that the Pluto version number can be found in
the About Pluto portlet, but it having the test in the testsuite ensures
that a version number check is done before a new version is released.
When a new build is staged for review, I always 'smoke test' the build
by running all the testsuite tests.
/Craig
Elliot Metsger wrote:
> I don't have any problem taking it out. IMHO its more trouble than
> its worth.
>
> Do others have any thoughts? It would mean taking that particular
> test - checkContextServerInfo - out of the test suite portlet. If we
> are concerned about ensuring its correctness (e.g. there are probably
> portlets that "container-sniff") we can replace it with a unit test
> using the full pluto version.
>
> Elliot
>
> David H. DeWolf wrote:
>> I thought that I had removed the notion of minor version from pluto.
>> Of course, we need it for the portlet api version, but I think we
>> just got too fancy for pluto versions.
>>
>> Elliot Metsger (JIRA) wrote:
>>> [
>>> https://issues.apache.org/jira/browse/PLUTO-319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477197
>>> ]
>>> Elliot Metsger commented on PLUTO-319:
>>> --------------------------------------
>>>
>>> I think this is because in the root pom.xml there is a property:
>>>
>>> <pluto.container.version.minor>1.0-SNAPSHOT</pluto.container.version.minor>
>>>
>>>
>>> I forgot to update that property. It is hard to automate the
>>> updating of that value because it is a "minor" version number.
>>> There there isn't a POM expression that we can use (that I know of)
>>> to get access to only the minor portion of the version.
>>>
>>>
>>>
>>>> checkContextServerInfo test on Misc Test page of Testsuite fails
>>>> ----------------------------------------------------------------
>>>>
>>>> Key: PLUTO-319
>>>> URL: https://issues.apache.org/jira/browse/PLUTO-319
>>>> Project: Pluto
>>>> Issue Type: Bug
>>>> Components: portlets-testsuite
>>>> Affects Versions: 1.1.0
>>>> Reporter: Craig Doremus
>>>> Priority: Minor
>>>> Fix For: 1.1.1
>>>>
>>>>
>>>> The checkContextServerInfo test on the Misc Test page of the
>>>> Testsuite fails. This is currently the only Testsuite test that
>>>> fails on Pluto 1.1.0 GA.
>>>
>
>
>
Re: [jira] Commented: (PLUTO-319) checkContextServerInfo test on
Misc Test page of Testsuite fails
Posted by "David H. DeWolf" <dd...@apache.org>.
Why would it mean that? Couldn't we just use the full version?
Elliot Metsger wrote:
> I don't have any problem taking it out. IMHO its more trouble than its
> worth.
>
> Do others have any thoughts? It would mean taking that particular test
> - checkContextServerInfo - out of the test suite portlet. If we are
> concerned about ensuring its correctness (e.g. there are probably
> portlets that "container-sniff") we can replace it with a unit test
> using the full pluto version.
>
> Elliot
>
> David H. DeWolf wrote:
>> I thought that I had removed the notion of minor version from pluto.
>> Of course, we need it for the portlet api version, but I think we just
>> got too fancy for pluto versions.
>>
>> Elliot Metsger (JIRA) wrote:
>>> [
>>> https://issues.apache.org/jira/browse/PLUTO-319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477197
>>> ]
>>> Elliot Metsger commented on PLUTO-319:
>>> --------------------------------------
>>>
>>> I think this is because in the root pom.xml there is a property:
>>>
>>> <pluto.container.version.minor>1.0-SNAPSHOT</pluto.container.version.minor>
>>>
>>>
>>> I forgot to update that property. It is hard to automate the
>>> updating of that value because it is a "minor" version number. There
>>> there isn't a POM expression that we can use (that I know of) to get
>>> access to only the minor portion of the version.
>>>
>>>
>>>
>>>> checkContextServerInfo test on Misc Test page of Testsuite fails
>>>> ----------------------------------------------------------------
>>>>
>>>> Key: PLUTO-319
>>>> URL: https://issues.apache.org/jira/browse/PLUTO-319
>>>> Project: Pluto
>>>> Issue Type: Bug
>>>> Components: portlets-testsuite
>>>> Affects Versions: 1.1.0
>>>> Reporter: Craig Doremus
>>>> Priority: Minor
>>>> Fix For: 1.1.1
>>>>
>>>>
>>>> The checkContextServerInfo test on the Misc Test page of the
>>>> Testsuite fails. This is currently the only Testsuite test that
>>>> fails on Pluto 1.1.0 GA.
>>>
>
Re: [jira] Commented: (PLUTO-319) checkContextServerInfo test on
Misc Test page of Testsuite fails
Posted by Elliot Metsger <em...@jhu.edu>.
I don't have any problem taking it out. IMHO its more trouble than its
worth.
Do others have any thoughts? It would mean taking that particular test
- checkContextServerInfo - out of the test suite portlet. If we are
concerned about ensuring its correctness (e.g. there are probably
portlets that "container-sniff") we can replace it with a unit test
using the full pluto version.
Elliot
David H. DeWolf wrote:
> I thought that I had removed the notion of minor version from pluto. Of
> course, we need it for the portlet api version, but I think we just got
> too fancy for pluto versions.
>
> Elliot Metsger (JIRA) wrote:
>> [
>> https://issues.apache.org/jira/browse/PLUTO-319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477197
>> ]
>> Elliot Metsger commented on PLUTO-319:
>> --------------------------------------
>>
>> I think this is because in the root pom.xml there is a property:
>>
>> <pluto.container.version.minor>1.0-SNAPSHOT</pluto.container.version.minor>
>>
>>
>> I forgot to update that property. It is hard to automate the updating
>> of that value because it is a "minor" version number. There there
>> isn't a POM expression that we can use (that I know of) to get access
>> to only the minor portion of the version.
>>
>>
>>
>>> checkContextServerInfo test on Misc Test page of Testsuite fails
>>> ----------------------------------------------------------------
>>>
>>> Key: PLUTO-319
>>> URL: https://issues.apache.org/jira/browse/PLUTO-319
>>> Project: Pluto
>>> Issue Type: Bug
>>> Components: portlets-testsuite
>>> Affects Versions: 1.1.0
>>> Reporter: Craig Doremus
>>> Priority: Minor
>>> Fix For: 1.1.1
>>>
>>>
>>> The checkContextServerInfo test on the Misc Test page of the
>>> Testsuite fails. This is currently the only Testsuite test that fails
>>> on Pluto 1.1.0 GA.
>>
Re: [jira] Commented: (PLUTO-319) checkContextServerInfo test on
Misc Test page of Testsuite fails
Posted by "David H. DeWolf" <dd...@apache.org>.
I thought that I had removed the notion of minor version from pluto. Of
course, we need it for the portlet api version, but I think we just got
too fancy for pluto versions.
Elliot Metsger (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/PLUTO-319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477197 ]
>
> Elliot Metsger commented on PLUTO-319:
> --------------------------------------
>
> I think this is because in the root pom.xml there is a property:
>
> <pluto.container.version.minor>1.0-SNAPSHOT</pluto.container.version.minor>
>
> I forgot to update that property. It is hard to automate the updating of that value because it is a "minor" version number. There there isn't a POM expression that we can use (that I know of) to get access to only the minor portion of the version.
>
>
>
>> checkContextServerInfo test on Misc Test page of Testsuite fails
>> ----------------------------------------------------------------
>>
>> Key: PLUTO-319
>> URL: https://issues.apache.org/jira/browse/PLUTO-319
>> Project: Pluto
>> Issue Type: Bug
>> Components: portlets-testsuite
>> Affects Versions: 1.1.0
>> Reporter: Craig Doremus
>> Priority: Minor
>> Fix For: 1.1.1
>>
>>
>> The checkContextServerInfo test on the Misc Test page of the Testsuite fails. This is currently the only Testsuite test that fails on Pluto 1.1.0 GA.
>