You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2018/07/27 13:09:03 UTC
[GitHub] vvysotskyi commented on a change in pull request #1406: DRILL-6641:
Fix columnValueCounts in ParquetGroupScanStatistics when ParquetGroupScan
has RowGroupInfo without column statistics
vvysotskyi commented on a change in pull request #1406: DRILL-6641: Fix columnValueCounts in ParquetGroupScanStatistics when ParquetGroupScan has RowGroupInfo without column statistics
URL: https://github.com/apache/drill/pull/1406#discussion_r205766709
##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScanStatistics.java
##########
@@ -88,19 +88,21 @@ public void collect(List<RowGroupInfo> rowGroupInfos, ParquetTableMetadataBase p
for (ColumnMetadata column : rowGroup.getColumns()) {
SchemaPath schemaPath = SchemaPath.getCompoundPath(column.getName());
Long previousCount = columnValueCounts.get(schemaPath);
+ Long newCount;
Review comment:
Thanks for the advice, with this change the code looks prettier!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services