You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/10/21 17:57:50 UTC

[GitHub] [incubator-tvm] tkonolige opened a new pull request #6725: [FIX,CMAKE] Use set_property with append flag instead of set_target_properties

tkonolige opened a new pull request #6725:
URL: https://github.com/apache/incubator-tvm/pull/6725


   `set_target_properties` does not append to existing properties. There were a couple place where previously set properties were overridden with different properties. For example, the debug flags for relay were not set correctly because `set_target_properties` was called twice in a row with different options.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #6725: [FIX,CMAKE] Use set_property with append flag instead of set_target_properties

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #6725:
URL: https://github.com/apache/incubator-tvm/pull/6725#issuecomment-714617365


   Thanks @tkonolige! It is now merged.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] jroesch commented on pull request #6725: [FIX,CMAKE] Use set_property with append flag instead of set_target_properties

Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #6725:
URL: https://github.com/apache/incubator-tvm/pull/6725#issuecomment-713835995


   cc @junrushao1994 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] junrushao1994 merged pull request #6725: [FIX,CMAKE] Use set_property with append flag instead of set_target_properties

Posted by GitBox <gi...@apache.org>.
junrushao1994 merged pull request #6725:
URL: https://github.com/apache/incubator-tvm/pull/6725


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #6725: [FIX,CMAKE] Use set_property with append flag instead of set_target_properties

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #6725:
URL: https://github.com/apache/incubator-tvm/pull/6725#issuecomment-713867363


   Right. We shouldn’t use SET_TARGET_PROPERTIES here. We should never use TARGET_LINK_LIBRARIES without private/public flags. Other fixes look good to me too! Thanks for the fix!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org