You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/02 18:43:12 UTC
[GitHub] [arrow] fsaintjacques commented on a change in pull request #7623: ARROW-9108: [C++][Dataset] Add supports for missing type in Statistics to Scalar conversion
fsaintjacques commented on a change in pull request #7623:
URL: https://github.com/apache/arrow/pull/7623#discussion_r449204595
##########
File path: python/pyarrow/tests/test_dataset.py
##########
@@ -760,6 +760,98 @@ def test_fragments_parquet_row_groups(tempdir):
assert len(result) == 1
+def _create_dataset_all_types(tempdir, chunk_size=None):
+ import pyarrow.parquet as pq
+
+ table = pa.table(
+ [
+ pa.array([True, None, False], pa.bool_()),
+ pa.array([1, 10, 42], pa.int8()),
+ pa.array([1, 10, 42], pa.uint8()),
+ pa.array([1, 10, 42], pa.int16()),
+ pa.array([1, 10, 42], pa.uint16()),
+ pa.array([1, 10, 42], pa.int32()),
+ pa.array([1, 10, 42], pa.uint32()),
+ pa.array([1, 10, 42], pa.int64()),
+ pa.array([1, 10, 42], pa.uint64()),
+ pa.array([1.0, 10.0, 42.0], pa.float32()),
+ pa.array([1.0, 10.0, 42.0], pa.float64()),
+ pa.array(['a', None, 'z'], pa.utf8()),
+ # pa.array(['a', None, 'z'], pa.binary()),
Review comment:
That's to be enabled once #7519 is merged, e.g. it is missing python Scalar classes.
##########
File path: python/pyarrow/tests/test_dataset.py
##########
@@ -760,6 +760,98 @@ def test_fragments_parquet_row_groups(tempdir):
assert len(result) == 1
+def _create_dataset_all_types(tempdir, chunk_size=None):
+ import pyarrow.parquet as pq
+
+ table = pa.table(
+ [
+ pa.array([True, None, False], pa.bool_()),
+ pa.array([1, 10, 42], pa.int8()),
+ pa.array([1, 10, 42], pa.uint8()),
+ pa.array([1, 10, 42], pa.int16()),
+ pa.array([1, 10, 42], pa.uint16()),
+ pa.array([1, 10, 42], pa.int32()),
+ pa.array([1, 10, 42], pa.uint32()),
+ pa.array([1, 10, 42], pa.int64()),
+ pa.array([1, 10, 42], pa.uint64()),
+ pa.array([1.0, 10.0, 42.0], pa.float32()),
+ pa.array([1.0, 10.0, 42.0], pa.float64()),
+ pa.array(['a', None, 'z'], pa.utf8()),
+ # pa.array(['a', None, 'z'], pa.binary()),
Review comment:
That's to be enabled once #7519 is merged, i.e. it is missing python Scalar classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org