You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/04/28 08:20:28 UTC
[GitHub] [ozone] adoroszlai opened a new pull request, #3362: Revert "HDDS-5740. Enable ratis by default for SCM."
adoroszlai opened a new pull request, #3362:
URL: https://github.com/apache/ozone/pull/3362
## What changes were proposed in this pull request?
Revert #2637. The PR was merged regardless of my [concern](https://github.com/apache/ozone/pull/2637#discussion_r778629887) about changing the default setting without providing seamless upgrade path. It turns out that enabling Ratis by default is indeed causing problems during upgrade.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5740
## How was this patch tested?
Regular CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/2237408109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3362: Revert "HDDS-5740. Enable ratis by default for SCM."
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3362:
URL: https://github.com/apache/ozone/pull/3362#issuecomment-1113673745
> I am +1 for reverting the change for now to get the incompatibility out of master. However, I see @mukul1987's point that for new clusters, at least 1 node Ratis for SCM would be the preferred default. I think we can come up with a way to do this in a follow-up PR.
I agree: if enabling SCM Ratis for single node has benefits, we can have an improvement Jira for that. But it is totally out of scope for this revert, as the original change is clearly breaking upgrades.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3362: Revert "HDDS-5740. Enable ratis by default for SCM."
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3362:
URL: https://github.com/apache/ozone/pull/3362#issuecomment-1112308654
@mukul1987 SCM HA is definitely recommended for new deployments. Please correct me if I'm wrong, but my understanding is that simply enabling Ratis for single-node SCM is not SCM HA, as that requires multiple nodes and explicit configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] errose28 commented on pull request #3362: Revert "HDDS-5740. Enable ratis by default for SCM."
Posted by GitBox <gi...@apache.org>.
errose28 commented on PR #3362:
URL: https://github.com/apache/ozone/pull/3362#issuecomment-1112620531
When upgrading from an old version to a version supporting SCM HA, none of the SCM HA configs are allowed to be turned on to prevent writing incompatible data before finalization. What happened with the original change was when a non-Ratis SCM was upgraded to a version supporting SCM HA, the ratis enabled flag was automatically set to true. The upgrade framework stopped this before any changes could be made, hence all pre-SCM HA clusters upgraded will fail immediately on startup with the message: `Configuration ozone.scm.ratis.enable cannot be used until SCM upgrade has been finalized`.
For the user to proceed, the config must be manually set to true and the cluster restarted, poor experience IMO. The upgrade acceptance tests correctly flagged this as incompatible, but they were modified in the original PR to mask the issue.
I am +1 for reverting the change for now to get the incompatibility out of master. However, I see @mukul1987's point that for new clusters, at least 1 node Ratis for SCM would be the preferred default. I think we can come up with a way to do this in a follow-up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3362: Revert "HDDS-5740. Enable ratis by default for SCM."
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3362:
URL: https://github.com/apache/ozone/pull/3362#issuecomment-1116322093
Thanks @errose28, @mukul1987 for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #3362: Revert "HDDS-5740. Enable ratis by default for SCM."
Posted by GitBox <gi...@apache.org>.
adoroszlai merged PR #3362:
URL: https://github.com/apache/ozone/pull/3362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org