You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/03/17 19:07:38 UTC
[GitHub] [activemq-artemis] clebertsuconic opened a new pull request #3026:
ARTEMIS-2662 Make Page to be resilient to invalid position
clebertsuconic opened a new pull request #3026: ARTEMIS-2662 Make Page to be resilient to invalid position
URL: https://github.com/apache/activemq-artemis/pull/3026
in case of an invalid position on getMessage, it should instead of runtimeException
be more resilient and fix itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] franz1981 commented on issue #3026: ARTEMIS-2662
Make Page to be resilient to invalid position
Posted by GitBox <gi...@apache.org>.
franz1981 commented on issue #3026: ARTEMIS-2662 Make Page to be resilient to invalid position
URL: https://github.com/apache/activemq-artemis/pull/3026#issuecomment-600308876
The idea is great, but I would use a warn (maybe): it shouldn't really happen, but when it happens it means that something isn't behaving correctly...I have not a strong opinion on this eh
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic commented on issue #3026:
ARTEMIS-2662 Make Page to be resilient to invalid position
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on issue #3026: ARTEMIS-2662 Make Page to be resilient to invalid position
URL: https://github.com/apache/activemq-artemis/pull/3026#issuecomment-600336018
I thought about using asserts... but I have a test that's testing for that condition, the assert would fail.
I am not sure about using log.warn here though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic commented on issue #3026:
ARTEMIS-2662 Make Page to be resilient to invalid position
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on issue #3026: ARTEMIS-2662 Make Page to be resilient to invalid position
URL: https://github.com/apache/activemq-artemis/pull/3026#issuecomment-600340402
so, I thought about log.warn. .but I wasn't 100% sure I would want it
I will do it log.warn.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] asfgit closed pull request #3026: ARTEMIS-2662
Make Page to be resilient to invalid position
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3026: ARTEMIS-2662 Make Page to be resilient to invalid position
URL: https://github.com/apache/activemq-artemis/pull/3026
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull
request #3026: ARTEMIS-2662 Make Page to be resilient to invalid position
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3026: ARTEMIS-2662 Make Page to be resilient to invalid position
URL: https://github.com/apache/activemq-artemis/pull/3026#discussion_r394403163
##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java
##########
@@ -1664,6 +1664,11 @@ void slowConsumerDetected(String sessionID,
format = Message.Format.MESSAGE_FORMAT)
void federationBindingsLookupError(@Cause Throwable e, SimpleString address);
+ @LogMessage(level = Logger.Level.WARN)
+ @Message(id = 222288, value = "Page {0}, message {1} could not be found on offset starring {2}, with starting message {3}. This represents a logic error or inconsistency on the data, and the system will try once again from the beggining of the page file.",
Review comment:
typo fixed. thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic commented on issue #3026:
ARTEMIS-2662 Make Page to be resilient to invalid position
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on issue #3026: ARTEMIS-2662 Make Page to be resilient to invalid position
URL: https://github.com/apache/activemq-artemis/pull/3026#issuecomment-600355456
@franz1981 since I don't have a strong opinion either.. I ammended to add log.warn
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] wy96f commented on a change in pull request
#3026: ARTEMIS-2662 Make Page to be resilient to invalid position
Posted by GitBox <gi...@apache.org>.
wy96f commented on a change in pull request #3026: ARTEMIS-2662 Make Page to be resilient to invalid position
URL: https://github.com/apache/activemq-artemis/pull/3026#discussion_r394076309
##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java
##########
@@ -1664,6 +1664,11 @@ void slowConsumerDetected(String sessionID,
format = Message.Format.MESSAGE_FORMAT)
void federationBindingsLookupError(@Cause Throwable e, SimpleString address);
+ @LogMessage(level = Logger.Level.WARN)
+ @Message(id = 222288, value = "Page {0}, message {1} could not be found on offset starring {2}, with starting message {3}. This represents a logic error or inconsistency on the data, and the system will try once again from the beggining of the page file.",
Review comment:
typo "starring"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services