You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2022/03/15 17:40:09 UTC
[tomcat] branch 10.0.x updated: Back-port additional false positives
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.0.x by this push:
new 767e258 Back-port additional false positives
767e258 is described below
commit 767e258d16f29ebd4feb05921466dbf751d6bf1a
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Tue Mar 15 17:39:59 2022 +0000
Back-port additional false positives
---
res/spotbugs/filter-false-positives.xml | 19 ++++++++++++++++---
1 file changed, 16 insertions(+), 3 deletions(-)
diff --git a/res/spotbugs/filter-false-positives.xml b/res/spotbugs/filter-false-positives.xml
index 912a7eb..1098c3b 100644
--- a/res/spotbugs/filter-false-positives.xml
+++ b/res/spotbugs/filter-false-positives.xml
@@ -2050,7 +2050,10 @@
<Match>
<!-- Return value of latch is intentionally ignored -->
<Class name="org.apache.catalina.nonblocking.TestNonBlockingAPI"/>
- <Method name="testDelayedNBWrite"/>
+ <Or>
+ <Method name="testDelayedNBReadWrite"/>
+ <Method name="testDelayedNBWrite"/>
+ </Or>
<Bug pattern="RV_RETURN_VALUE_IGNORED"/>
</Match>
<Match>
@@ -2253,13 +2256,17 @@
<Bug code="DE" />
</Match>
<Match>
- <!-- Non-constant is just a split constant -->
<Class name="org.apache.catalina.users.DataSourceUserDatabaseTests"/>
<Or>
<Method name="testBasicUserRoleDatabase"/>
<Method name="testUserDatabase"/>
</Or>
- <Bug pattern="SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE"/>
+ <Or>
+ <!-- There is no null check - SpotBugs bug? -->
+ <Bug pattern="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE"/>
+ <!-- Non-constant is just a split constant -->
+ <Bug pattern="SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE"/>
+ </Or>
</Match>
<Match>
<!-- Concrete Map type not affected -->
@@ -2623,4 +2630,10 @@
</Or>
<Bug pattern="RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT"/>
</Match>
+ <Match>
+ <!-- There is no null check - SpotBugs bug? -->
+ <Class name="org.apache.tomcat.websocket.server.TestWsServerContainer" />
+ <Method name="testBug58232" />
+ <Bug pattern="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE"/>
+ </Match>
</FindBugsFilter>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org