You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/10/29 00:29:18 UTC

[GitHub] [airflow] uranusjr edited a comment on issue #19264: TriggerDagRunOperator External Link doesn't link with execution date to match to triggered DAG

uranusjr edited a comment on issue #19264:
URL: https://github.com/apache/airflow/issues/19264#issuecomment-954317936


   I dug through history and it seems like `TriggerDagRunOperator`'s extra link is simply out of date. The link was added in ff1ab9714dc57de05a9a8695753f73e7ac18f074, at which point `/graph` indeed took an `execution_date`:
   
   https://github.com/apache/airflow/blob/ff1ab9714dc57de05a9a8695753f73e7ac18f074/airflow/www/views.py#L100-L104
   
   But the graph endpoint later went through some refactoring and now takes a `base_date` instead. So we should fix the extra link to pass the right argument. Feel free to submit a fix for this! (And if possible, a way to write tests so this doesn't break again in the future.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org