[GitHub] [submarine] tangzhankun commented on a change in pull request #446: SUBMARINE-672. Remove unused dependencies from pom.xml

[GitBox <gi...@apache.org>]

tangzhankun commented on a change in pull request #446:
URL: https://github.com/apache/submarine/pull/446#discussion_r517093271



##########
File path: submarine-dist/src/assembly/distribution.xml
##########
@@ -138,10 +138,6 @@
         <include>submarine-submitter-k8s-${project.version}.jar</include>
       </includes>
     </fileSet>
-    <fileSet>
-      <directory>../submarine-server/server-submitter/submitter-k8s/target/dependency</directory>
-      <outputDirectory>/lib/submitter/k8s</outputDirectory>
-    </fileSet>

Review comment:
       If we don't copy the submitter jars, can it still submit jobs?

##########
File path: submarine-dist/src/assembly/distribution.xml
##########
@@ -185,6 +181,11 @@
         <!-- atomix & netty-4.1.27.Final already shade in submarine-commons-cluster-${project.version}-shade.jar -->
         <exclude>atomix-*.jar</exclude>
         <exclude>netty-*-4.1.27.Final*.jar</exclude>
+        <exclude>submarine-cloud/bin/**</exclude>
+        <exclude>dev-support/submarine-installer/package/hadoop/yarn/lib/native/**</exclude>

Review comment:
       The "<exclude>submarine-cloud/bin/**</exclude>" and "<exclude>dev-support/submarine-installer/package/hadoop/yarn/lib/native/**</exclude>" seems should be put in the "submarine-dist/src/assembly/src-distribution.xml"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org