[PATCH] Translation work in the cmdline client

["Peter N. Lundblad" <lu...@softhome.net>]

Hi,

Here are some missing _() additions in the command line client. On ehcnage
that might be controversial is the localization of the EOF prefix in the
default log messages. I think it should be translated, since it is a
message to the user even if it's put in the message file.

Regards,
//Peter

Re: [PATCH] Translation work in the cmdline client

["Peter N. Lundblad" <lu...@softhome.net>]

Hi,

On Tue, 4 May 2004, Erik Huelsmann wrote:

>
> > > >     case svn_wc_notify_commit_deleted:
> > > >-      printf ("Deleting       %s\n", path_stdout);
> > > >+      printf (_("Deleting       %s\n"), path_stdout);
> > > >       break;
> > > >
> > > >
> > > You should add comments for translators here, explaining that these
> > > three messages must be aligned.
> > >
[...]
> In r9616 I checked in a change to the pot file generation target which
> copies comments on the line preceding the _() calls. You should be able to
> add the required comments now.
>
Yes, it works. Here's the patch with the added comment.

//Peter

Re: [PATCH] Translation work in the cmdline client

[Branko Čibej <br...@xbc.nu>]

Peter N. Lundblad wrote:

>Do you mean plain comments in the source or is there some way to add
>comments that will survive into the .pot file so that the translator will
>see them without having to jump to the position in the sources?
>  
>
The latter, of course. See the xgettext docs about the -c flag; IIRC any 
comment that starts with "xgettext:" will be reproduced in the .pot file 
if you pass-c to xgettext.

-- Brane



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Translation work in the cmdline client

["Peter N. Lundblad" <lu...@softhome.net>]

On Sat, 1 May 2004, [UTF-8] Branko Ä^Libej wrote:

> Peter N. Lundblad wrote:
>
> >Index: subversion/clients/cmdline/notify.c
> >===================================================================
> >--- subversion/clients/cmdline/notify.c	(revision 9586)
> >+++ subversion/clients/cmdline/notify.c	(working copy)
> >@@ -232,13 +232,13 @@
> >
> >     case svn_wc_notify_commit_added:
> >       if (mime_type && svn_mime_type_is_binary (mime_type))
> >-        printf ("Adding  (bin)  %s\n", path_stdout);
> >+        printf (_("Adding  (bin)  %s\n"), path_stdout);
> >       else
> >-        printf ("Adding         %s\n", path_stdout);
> >+        printf (_("Adding         %s\n"), path_stdout);
> >       break;
> >
> >     case svn_wc_notify_commit_deleted:
> >-      printf ("Deleting       %s\n", path_stdout);
> >+      printf (_("Deleting       %s\n"), path_stdout);
> >       break;
> >
> >
> You should add comments for translators here, explaining that these
> three messages must be aligned.
>
Do you mean plain comments in the source or is there some way to add
comments that will survive into the .pot file so that the translator will
see them without having to jump to the position in the sources?

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Translation work in the cmdline client

[Branko Čibej <br...@xbc.nu>]

Peter N. Lundblad wrote:

>Index: subversion/clients/cmdline/notify.c
>===================================================================
>--- subversion/clients/cmdline/notify.c	(revision 9586)
>+++ subversion/clients/cmdline/notify.c	(working copy)
>@@ -232,13 +232,13 @@
> 
>     case svn_wc_notify_commit_added:
>       if (mime_type && svn_mime_type_is_binary (mime_type))
>-        printf ("Adding  (bin)  %s\n", path_stdout);
>+        printf (_("Adding  (bin)  %s\n"), path_stdout);
>       else
>-        printf ("Adding         %s\n", path_stdout);
>+        printf (_("Adding         %s\n"), path_stdout);
>       break;
> 
>     case svn_wc_notify_commit_deleted:
>-      printf ("Deleting       %s\n", path_stdout);
>+      printf (_("Deleting       %s\n"), path_stdout);
>       break;
>  
>
You should add comments for translators here, explaining that these 
three messages must be aligned.

-- Brane



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org