You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/10/01 13:01:22 UTC
[GitHub] [hudi] nsivabalan opened a new pull request #3742: [HUDI-2512][WIP] Fixing adding extra metadata for multi-writer
nsivabalan opened a new pull request #3742:
URL: https://github.com/apache/hudi/pull/3742
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #3742: [HUDI-2512][WIP] Fixing adding extra metadata for multi-writer
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #3742:
URL: https://github.com/apache/hudi/pull/3742#issuecomment-939078694
Closing this as its not required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3742: [HUDI-2512][WIP] Fixing adding extra metadata for multi-writer
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3742:
URL: https://github.com/apache/hudi/pull/3742#issuecomment-932209027
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5bb333177ef1f7bb68480c2b890df6c236a30624",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2481",
"triggerID" : "5bb333177ef1f7bb68480c2b890df6c236a30624",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5bb333177ef1f7bb68480c2b890df6c236a30624 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2481)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3742: [HUDI-2512][WIP] Fixing adding extra metadata for multi-writer
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3742:
URL: https://github.com/apache/hudi/pull/3742#issuecomment-932209027
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5bb333177ef1f7bb68480c2b890df6c236a30624",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2481",
"triggerID" : "5bb333177ef1f7bb68480c2b890df6c236a30624",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5bb333177ef1f7bb68480c2b890df6c236a30624 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2481)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan closed pull request #3742: [HUDI-2512][WIP] Fixing adding extra metadata for multi-writer
Posted by GitBox <gi...@apache.org>.
nsivabalan closed pull request #3742:
URL: https://github.com/apache/hudi/pull/3742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #3742: [HUDI-2512][WIP] Fixing adding extra metadata for multi-writer
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #3742:
URL: https://github.com/apache/hudi/pull/3742#issuecomment-933618714
@n3nash @vinothchandar : Wanted to discuss how we can support multi-writer across deltastreamer and spark-ds. As of now, looks like copying the metadata from previous commit to current one is missing in spark-ds and I have fixed it here. But this requires users to set hoodie.datasource.write.commitmeta.key.prefix="deltastreamer.checkpoint.key" with spark-ds. wondering if this is the right fix. If yes, do we really need the user to set this config? can't we infer automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3742: [HUDI-2512][WIP] Fixing adding extra metadata for multi-writer
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3742:
URL: https://github.com/apache/hudi/pull/3742#issuecomment-932209027
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5bb333177ef1f7bb68480c2b890df6c236a30624",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5bb333177ef1f7bb68480c2b890df6c236a30624",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5bb333177ef1f7bb68480c2b890df6c236a30624 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org