You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Hans Bakker <ma...@antwebsystems.com> on 2008/12/25 08:56:48 UTC
Re: svn commit: r729396 [1/2] - in /ofbiz/trunk:
applications/accounting/config/ applications/accounting/entitydef/
applications/accounting/src/org/ofbiz/accounting/invoice/
applications/accounting/src/org/ofbiz/accounting/payment/ applications/accou
Bruno, David,
I have no problem changing this commit, but could you please tell me how
to do that? How can the framework be independent of the party entity?
We have to remove the header.ftl and the common/widget/commonscreens.xml
files out of the framework...not only because of this commit..... where
to? Actually the whole "common" component has to be moved out...
This commit only changes this common component......
can you please advise.....
Regards.
Hans
PS. i did a scan of "Party" in the framework and found 217 matches....
On Thu, 2008-12-25 at 00:31 -0700, David E Jones wrote:
> The decision has already been made, and even documented (a miracle,
> yes I know). For details see:
>
> http://docs.ofbiz.org/display/OFBADMIN/Component+and+Component+Set+Dependencies
>
> Now we just need to stick to it... so thanks for bringing this up Bruno.
>
> -David
>
>
> On Dec 25, 2008, at 12:27 AM, Bruno Busco wrote:
>
> > Hi,
> > this change sets an additional dependence of the framework from the
> > Party application.
> > We should definitively take a decition on how to separate the
> > framework.
> >
> > -Bruno
> >
> > 2008/12/25 <ha...@apache.org>:
> >> Author: hansbak
> >> Date: Wed Dec 24 22:26:14 2008
> >> New Revision: 729396
> >>
> >> URL: http://svn.apache.org/viewvc?rev=729396&view=rev
> >> Log:
> >> OFBIZ-2097: show organizationPartyId in header(can be set in
> >> preferences), rewrote financial history to show currencies, invoice/
> >> p[aymentworker now can show in actual and organizationparty currency
> >>
> >> Added:
> >> ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/actions/
> >> party/UnAppliedInvoicesForParty.groovy (with props)
> >> ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/actions/
> >> party/UnAppliedPaymentsForParty.groovy (with props)
> >> Modified:
> >> ofbiz/trunk/applications/accounting/config/AccountingUiLabels.xml
> >> ofbiz/trunk/applications/accounting/entitydef/entitymodel.xml
> >> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/
> >> invoice/InvoiceWorker.java
> >> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/
> >> payment/PaymentWorker.java
> >> ofbiz/trunk/applications/accounting/webapp/accounting/WEB-INF/
> >> actions/invoice/EditInvoice.groovy
> >> ofbiz/trunk/applications/accounting/webapp/accounting/invoice/
> >> InvoiceForms.xml
> >> ofbiz/trunk/applications/accounting/webapp/accounting/payment/
> >> PaymentForms.xml
> >> ofbiz/trunk/applications/accounting/widget/InvoiceScreens.xml
> >> ofbiz/trunk/applications/accounting/widget/Menus.xml
> >> ofbiz/trunk/applications/party/entitydef/entitymodel.xml
> >> ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/actions/
> >> party/PartyFinancialHistory.groovy
> >> ofbiz/trunk/applications/party/webapp/partymgr/party/PartyForms.xml
> >> ofbiz/trunk/applications/party/widget/partymgr/PartyScreens.xml
> >> ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml
> >> ofbiz/trunk/framework/common/config/CommonUiLabels.xml
> >> ofbiz/trunk/framework/common/webcommon/includes/header.ftl
> >> ofbiz/trunk/framework/common/widget/CommonScreens.xml
> >>
>
--
Antwebsystems.com: Quality OFBiz services for competitive prices
Re: svn commit: r729396 [1/2] - in /ofbiz/trunk:
applications/accounting/config/ applications/accounting/entitydef/
applications/accounting/src/org/ofbiz/accounting/invoice/
applications/accounting/src/org/ofbiz/accounting/payment/ applications/accou
Posted by Hans Bakker <ma...@antwebsystems.com>.
I think the only way out of this is to create a "common" component in
the application folder where these files can go......
Regards, Hans
On Thu, 2008-12-25 at 09:18 +0100, Bruno Busco wrote:
> Hans,
> of course there is lot of work to do to have the framework separated
> but we should avoid to do work in the opposite direction.
>
> For example:
> in the header info the visual-theme, the language and the timezone and
> userLoginId are all ok (framework defined),
> the person and groupname info (ond now organization also) should be moved away.
>
> I was thinking to change the login portlet that is now put as a demo
> in the common component to show basic framework-defined user info like
> the userLoginId, visual-theme, langiage and timezone when a user is
> logged in.
> An additional portlet (defined in the party application) could show
> the person, group and organization info for the logged in user.
>
> Then a home portal page could be configured to show only login portlet
> in the framework.
> The partymgr application could add the new portlet to the home portal
> using additional application datas.
>
> WDYT?
> We should only agree to a pattern and try to follow it.
>
> -Bruno
>
> 2008/12/25 Hans Bakker <ma...@antwebsystems.com>:
> > Bruno, David,
> >
> > I have no problem changing this commit, but could you please tell me how
> > to do that? How can the framework be independent of the party entity?
> >
> > We have to remove the header.ftl and the common/widget/commonscreens.xml
> > files out of the framework...not only because of this commit..... where
> > to? Actually the whole "common" component has to be moved out...
> >
> > This commit only changes this common component......
> >
> > can you please advise.....
> >
> > Regards.
> > Hans
> >
> > PS. i did a scan of "Party" in the framework and found 217 matches....
> >
> >
> >
> > On Thu, 2008-12-25 at 00:31 -0700, David E Jones wrote:
> >> The decision has already been made, and even documented (a miracle,
> >> yes I know). For details see:
> >>
> >> http://docs.ofbiz.org/display/OFBADMIN/Component+and+Component+Set+Dependencies
> >>
> >> Now we just need to stick to it... so thanks for bringing this up Bruno.
> >>
> >> -David
> >>
> >>
> >> On Dec 25, 2008, at 12:27 AM, Bruno Busco wrote:
> >>
> >> > Hi,
> >> > this change sets an additional dependence of the framework from the
> >> > Party application.
> >> > We should definitively take a decition on how to separate the
> >> > framework.
> >> >
> >> > -Bruno
> >> >
> >> > 2008/12/25 <ha...@apache.org>:
> >> >> Author: hansbak
> >> >> Date: Wed Dec 24 22:26:14 2008
> >> >> New Revision: 729396
> >> >>
> >> >> URL: http://svn.apache.org/viewvc?rev=729396&view=rev
> >> >> Log:
> >> >> OFBIZ-2097: show organizationPartyId in header(can be set in
> >> >> preferences), rewrote financial history to show currencies, invoice/
> >> >> p[aymentworker now can show in actual and organizationparty currency
> >> >>
> >> >> Added:
> >> >> ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/actions/
> >> >> party/UnAppliedInvoicesForParty.groovy (with props)
> >> >> ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/actions/
> >> >> party/UnAppliedPaymentsForParty.groovy (with props)
> >> >> Modified:
> >> >> ofbiz/trunk/applications/accounting/config/AccountingUiLabels.xml
> >> >> ofbiz/trunk/applications/accounting/entitydef/entitymodel.xml
> >> >> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/
> >> >> invoice/InvoiceWorker.java
> >> >> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/
> >> >> payment/PaymentWorker.java
> >> >> ofbiz/trunk/applications/accounting/webapp/accounting/WEB-INF/
> >> >> actions/invoice/EditInvoice.groovy
> >> >> ofbiz/trunk/applications/accounting/webapp/accounting/invoice/
> >> >> InvoiceForms.xml
> >> >> ofbiz/trunk/applications/accounting/webapp/accounting/payment/
> >> >> PaymentForms.xml
> >> >> ofbiz/trunk/applications/accounting/widget/InvoiceScreens.xml
> >> >> ofbiz/trunk/applications/accounting/widget/Menus.xml
> >> >> ofbiz/trunk/applications/party/entitydef/entitymodel.xml
> >> >> ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/actions/
> >> >> party/PartyFinancialHistory.groovy
> >> >> ofbiz/trunk/applications/party/webapp/partymgr/party/PartyForms.xml
> >> >> ofbiz/trunk/applications/party/widget/partymgr/PartyScreens.xml
> >> >> ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml
> >> >> ofbiz/trunk/framework/common/config/CommonUiLabels.xml
> >> >> ofbiz/trunk/framework/common/webcommon/includes/header.ftl
> >> >> ofbiz/trunk/framework/common/widget/CommonScreens.xml
> >> >>
> >>
> > --
> > Antwebsystems.com: Quality OFBiz services for competitive prices
> >
> >
--
Antwebsystems.com: Quality OFBiz services for competitive prices
Re: svn commit: r729396 [1/2] - in /ofbiz/trunk: applications/accounting/config/ applications/accounting/entitydef/ applications/accounting/src/org/ofbiz/accounting/invoice/ applications/accounting/src/org/ofbiz/accounting/payment/ applications/accou
Posted by Bruno Busco <br...@gmail.com>.
Hans,
of course there is lot of work to do to have the framework separated
but we should avoid to do work in the opposite direction.
For example:
in the header info the visual-theme, the language and the timezone and
userLoginId are all ok (framework defined),
the person and groupname info (ond now organization also) should be moved away.
I was thinking to change the login portlet that is now put as a demo
in the common component to show basic framework-defined user info like
the userLoginId, visual-theme, langiage and timezone when a user is
logged in.
An additional portlet (defined in the party application) could show
the person, group and organization info for the logged in user.
Then a home portal page could be configured to show only login portlet
in the framework.
The partymgr application could add the new portlet to the home portal
using additional application datas.
WDYT?
We should only agree to a pattern and try to follow it.
-Bruno
2008/12/25 Hans Bakker <ma...@antwebsystems.com>:
> Bruno, David,
>
> I have no problem changing this commit, but could you please tell me how
> to do that? How can the framework be independent of the party entity?
>
> We have to remove the header.ftl and the common/widget/commonscreens.xml
> files out of the framework...not only because of this commit..... where
> to? Actually the whole "common" component has to be moved out...
>
> This commit only changes this common component......
>
> can you please advise.....
>
> Regards.
> Hans
>
> PS. i did a scan of "Party" in the framework and found 217 matches....
>
>
>
> On Thu, 2008-12-25 at 00:31 -0700, David E Jones wrote:
>> The decision has already been made, and even documented (a miracle,
>> yes I know). For details see:
>>
>> http://docs.ofbiz.org/display/OFBADMIN/Component+and+Component+Set+Dependencies
>>
>> Now we just need to stick to it... so thanks for bringing this up Bruno.
>>
>> -David
>>
>>
>> On Dec 25, 2008, at 12:27 AM, Bruno Busco wrote:
>>
>> > Hi,
>> > this change sets an additional dependence of the framework from the
>> > Party application.
>> > We should definitively take a decition on how to separate the
>> > framework.
>> >
>> > -Bruno
>> >
>> > 2008/12/25 <ha...@apache.org>:
>> >> Author: hansbak
>> >> Date: Wed Dec 24 22:26:14 2008
>> >> New Revision: 729396
>> >>
>> >> URL: http://svn.apache.org/viewvc?rev=729396&view=rev
>> >> Log:
>> >> OFBIZ-2097: show organizationPartyId in header(can be set in
>> >> preferences), rewrote financial history to show currencies, invoice/
>> >> p[aymentworker now can show in actual and organizationparty currency
>> >>
>> >> Added:
>> >> ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/actions/
>> >> party/UnAppliedInvoicesForParty.groovy (with props)
>> >> ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/actions/
>> >> party/UnAppliedPaymentsForParty.groovy (with props)
>> >> Modified:
>> >> ofbiz/trunk/applications/accounting/config/AccountingUiLabels.xml
>> >> ofbiz/trunk/applications/accounting/entitydef/entitymodel.xml
>> >> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/
>> >> invoice/InvoiceWorker.java
>> >> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/
>> >> payment/PaymentWorker.java
>> >> ofbiz/trunk/applications/accounting/webapp/accounting/WEB-INF/
>> >> actions/invoice/EditInvoice.groovy
>> >> ofbiz/trunk/applications/accounting/webapp/accounting/invoice/
>> >> InvoiceForms.xml
>> >> ofbiz/trunk/applications/accounting/webapp/accounting/payment/
>> >> PaymentForms.xml
>> >> ofbiz/trunk/applications/accounting/widget/InvoiceScreens.xml
>> >> ofbiz/trunk/applications/accounting/widget/Menus.xml
>> >> ofbiz/trunk/applications/party/entitydef/entitymodel.xml
>> >> ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/actions/
>> >> party/PartyFinancialHistory.groovy
>> >> ofbiz/trunk/applications/party/webapp/partymgr/party/PartyForms.xml
>> >> ofbiz/trunk/applications/party/widget/partymgr/PartyScreens.xml
>> >> ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml
>> >> ofbiz/trunk/framework/common/config/CommonUiLabels.xml
>> >> ofbiz/trunk/framework/common/webcommon/includes/header.ftl
>> >> ofbiz/trunk/framework/common/widget/CommonScreens.xml
>> >>
>>
> --
> Antwebsystems.com: Quality OFBiz services for competitive prices
>
>