You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Jukka Zitting (JIRA)" <ji...@apache.org> on 2010/09/29 14:38:32 UTC
[jira] Created: (JCR-2763) Drop the Dumpable interface
Drop the Dumpable interface
---------------------------
Key: JCR-2763
URL: https://issues.apache.org/jira/browse/JCR-2763
Project: Jackrabbit Content Repository
Issue Type: Improvement
Components: jackrabbit-core
Reporter: Jukka Zitting
Priority: Trivial
I belive the o.a.j.core.util.Dumpable interface was originally used for diagnostic purposes, but AFAIUI we don't use it anywhere anymore. I'd like to drop the interface and refactor the dump() methods in various Jackrabbit classes to more detailed toString() methods that would be more useful to debuggers and other general-purpose diagnostic tools.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-2763) Drop the Dumpable interface
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated JCR-2763:
-------------------------------
Component/s: jackrabbit-spi2jcr
Done in revision 1004622 for jackrabbit-core. There's a similar interface also in jackrabbit-jcr2spi, which I'd also like to replace with standard toString() methods.
> Drop the Dumpable interface
> ---------------------------
>
> Key: JCR-2763
> URL: https://issues.apache.org/jira/browse/JCR-2763
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core, jackrabbit-spi2jcr
> Reporter: Jukka Zitting
> Priority: Trivial
>
> I belive the o.a.j.core.util.Dumpable interface was originally used for diagnostic purposes, but AFAIUI we don't use it anywhere anymore. I'd like to drop the interface and refactor the dump() methods in various Jackrabbit classes to more detailed toString() methods that would be more useful to debuggers and other general-purpose diagnostic tools.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-2763) Drop the Dumpable interface
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918494#action_12918494 ]
Jukka Zitting commented on JCR-2763:
------------------------------------
> what about SessionImpl.dump()?
I dropped it because SessionImpl already had a toString() method and it seemed wrong to include too many internal details in the return value of a method that's directly accessible by JCR clients. We could instead print out the component details in SessionContext.toString(). I'll take a look at that.
> i fail to see any benefit in removing this interface. what was your motivation?
The same functionality can be implemented in a more interoperable way using toString() methods. As an added bonus we even get rid of one extra internal abstraction.
> Drop the Dumpable interface
> ---------------------------
>
> Key: JCR-2763
> URL: https://issues.apache.org/jira/browse/JCR-2763
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core, jackrabbit-spi2jcr
> Reporter: Jukka Zitting
> Priority: Trivial
>
> I belive the o.a.j.core.util.Dumpable interface was originally used for diagnostic purposes, but AFAIUI we don't use it anywhere anymore. I'd like to drop the interface and refactor the dump() methods in various Jackrabbit classes to more detailed toString() methods that would be more useful to debuggers and other general-purpose diagnostic tools.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JCR-2763) Drop the Dumpable interface
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting resolved JCR-2763.
--------------------------------
Resolution: Fixed
Fix Version/s: 2.2.0
Assignee: Jukka Zitting
Done also for jcr2spi in revision 1032651.
> Drop the Dumpable interface
> ---------------------------
>
> Key: JCR-2763
> URL: https://issues.apache.org/jira/browse/JCR-2763
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core, jackrabbit-spi2jcr
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Priority: Trivial
> Fix For: 2.2.0
>
>
> I belive the o.a.j.core.util.Dumpable interface was originally used for diagnostic purposes, but AFAIUI we don't use it anywhere anymore. I'd like to drop the interface and refactor the dump() methods in various Jackrabbit classes to more detailed toString() methods that would be more useful to debuggers and other general-purpose diagnostic tools.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-2763) Drop the Dumpable interface
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918512#action_12918512 ]
Jukka Zitting commented on JCR-2763:
------------------------------------
In revision 1005019 I restored the essential functionality of SessionImpl.dump() in the SessionContext.toString() method.
> Drop the Dumpable interface
> ---------------------------
>
> Key: JCR-2763
> URL: https://issues.apache.org/jira/browse/JCR-2763
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core, jackrabbit-spi2jcr
> Reporter: Jukka Zitting
> Priority: Trivial
>
> I belive the o.a.j.core.util.Dumpable interface was originally used for diagnostic purposes, but AFAIUI we don't use it anywhere anymore. I'd like to drop the interface and refactor the dump() methods in various Jackrabbit classes to more detailed toString() methods that would be more useful to debuggers and other general-purpose diagnostic tools.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-2763) Drop the Dumpable interface
Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918516#action_12918516 ]
Stefan Guggisberg commented on JCR-2763:
----------------------------------------
> In revision 1005019 I restored the essential functionality of SessionImpl.dump() in the SessionContext.toString() method.
thanks!
> Drop the Dumpable interface
> ---------------------------
>
> Key: JCR-2763
> URL: https://issues.apache.org/jira/browse/JCR-2763
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core, jackrabbit-spi2jcr
> Reporter: Jukka Zitting
> Priority: Trivial
>
> I belive the o.a.j.core.util.Dumpable interface was originally used for diagnostic purposes, but AFAIUI we don't use it anywhere anymore. I'd like to drop the interface and refactor the dump() methods in various Jackrabbit classes to more detailed toString() methods that would be more useful to debuggers and other general-purpose diagnostic tools.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-2763) Drop the Dumpable interface
Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918482#action_12918482 ]
Stefan Guggisberg commented on JCR-2763:
----------------------------------------
what about SessionImpl.dump()? it used to dump the internal session state, e.g. transient items etc.
it proofed to be quite useful while debugging, at least for me.
btw: i fail to see any benefit in removing this interface. what was your motivation?
> Drop the Dumpable interface
> ---------------------------
>
> Key: JCR-2763
> URL: https://issues.apache.org/jira/browse/JCR-2763
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core, jackrabbit-spi2jcr
> Reporter: Jukka Zitting
> Priority: Trivial
>
> I belive the o.a.j.core.util.Dumpable interface was originally used for diagnostic purposes, but AFAIUI we don't use it anywhere anymore. I'd like to drop the interface and refactor the dump() methods in various Jackrabbit classes to more detailed toString() methods that would be more useful to debuggers and other general-purpose diagnostic tools.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.