You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2004/06/07 00:24:57 UTC
cvs commit: jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/sampler AccessLogSampler.java WebServiceSampler.java HTTPSamplerBase.java PostWriter.java
sebb 2004/06/06 15:24:57
Modified: src/protocol/http/org/apache/jmeter/protocol/http/sampler
AccessLogSampler.java WebServiceSampler.java
HTTPSamplerBase.java PostWriter.java
Log:
Reduce visibility of fields; comment out unread fields
Revision Changes Path
1.12 +3 -3 jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/sampler/AccessLogSampler.java
Index: AccessLogSampler.java
===================================================================
RCS file: /home/cvs/jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/sampler/AccessLogSampler.java,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -r1.11 -r1.12
--- AccessLogSampler.java 28 May 2004 21:09:13 -0000 1.11
+++ AccessLogSampler.java 6 Jun 2004 22:24:57 -0000 1.12
@@ -71,7 +71,7 @@
/** private members used by class * */
transient private LogParser PARSER = null;
- private Class PARSERCLASS = null;
+ //NOTUSED private Class PARSERCLASS = null;
private String logFile, parserClassName, filterClassName;
private Filter filter;
private int count = 0;
1.16 +7 -7 jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/sampler/WebServiceSampler.java
Index: WebServiceSampler.java
===================================================================
RCS file: /home/cvs/jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/sampler/WebServiceSampler.java,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -r1.15 -r1.16
--- WebServiceSampler.java 13 Mar 2004 19:44:14 -0000 1.15
+++ WebServiceSampler.java 6 Jun 2004 22:24:57 -0000 1.16
@@ -73,17 +73,17 @@
* webservices and is defined by the
* WSDL.
*/
- protected String SOAPACTION = null;
+ private String SOAPACTION = null;
/**
* SampleResult which holds the response
*/
- transient SampleResult RESULT = null;
+ private transient SampleResult RESULT = null;
/**
* The XML document
*/
- protected Document XMLMSG = null;
+ private Document XMLMSG = null;
/**
* size of File[] array
@@ -109,9 +109,9 @@
* consider using Apache commons pool to create a pool of document builders
* or make sure XMLParserUtils creates builders efficiently.
*/
- protected static DocumentBuilder XDB = null;
+ private static DocumentBuilder XDB = null;
- protected String FILE_CONTENTS = null;
+ private String FILE_CONTENTS = null;
/**
* Set the path where XML messages are stored for random selection.
1.3 +3 -3 jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
Index: HTTPSamplerBase.java
===================================================================
RCS file: /home/cvs/jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- HTTPSamplerBase.java 20 May 2004 19:18:41 -0000 1.2
+++ HTTPSamplerBase.java 6 Jun 2004 22:24:57 -0000 1.3
@@ -594,7 +594,7 @@
protected abstract HTTPSampleResult sample(URL u, String s, boolean b, int i);
- protected static Pattern pattern;
+ private static final Pattern pattern;
private static ThreadLocal localMatcher = new ThreadLocal()
{
protected synchronized Object initialValue()
1.14 +3 -3 jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/sampler/PostWriter.java
Index: PostWriter.java
===================================================================
RCS file: /home/cvs/jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/sampler/PostWriter.java,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -r1.13 -r1.14
--- PostWriter.java 16 Apr 2004 13:21:45 -0000 1.13
+++ PostWriter.java 6 Jun 2004 22:24:57 -0000 1.14
@@ -39,7 +39,7 @@
{
protected final static String BOUNDARY =
"---------------------------7d159c1302d0y0";
- protected final static byte[] CRLF = { 0x0d, 0x0A };//TODO: make private?
+ private final static byte[] CRLF = { 0x0d, 0x0A };
//protected static int fudge = -20;
protected static final String encoding = "iso-8859-1";
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org