You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@phoenix.apache.org by el...@apache.org on 2017/01/06 05:06:10 UTC
[1/6] phoenix git commit: PHOENIX-3557 Provide a good error message
when an invalid test pattern was provided
Repository: phoenix
Updated Branches:
refs/heads/4.x-HBase-0.98 8ba67b3e6 -> 91d1478cf
refs/heads/4.x-HBase-1.1 2e7a8c6ef -> e24ec6a8e
refs/heads/master a0e5efcec -> a164f0327
PHOENIX-3557 Provide a good error message when an invalid test pattern was provided
Project: http://git-wip-us.apache.org/repos/asf/phoenix/repo
Commit: http://git-wip-us.apache.org/repos/asf/phoenix/commit/e4c6f5cd
Tree: http://git-wip-us.apache.org/repos/asf/phoenix/tree/e4c6f5cd
Diff: http://git-wip-us.apache.org/repos/asf/phoenix/diff/e4c6f5cd
Branch: refs/heads/master
Commit: e4c6f5cde940931bb4be82c7aa7959de58857ad8
Parents: a0e5efc
Author: Josh Elser <el...@apache.org>
Authored: Thu Jan 5 13:37:59 2017 -0500
Committer: Josh Elser <el...@apache.org>
Committed: Thu Jan 5 22:19:13 2017 -0500
----------------------------------------------------------------------
.../org/apache/phoenix/end2end/End2EndTestDriver.java | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/phoenix/blob/e4c6f5cd/phoenix-core/src/it/java/org/apache/phoenix/end2end/End2EndTestDriver.java
----------------------------------------------------------------------
diff --git a/phoenix-core/src/it/java/org/apache/phoenix/end2end/End2EndTestDriver.java b/phoenix-core/src/it/java/org/apache/phoenix/end2end/End2EndTestDriver.java
index a505c1e..feb506f 100644
--- a/phoenix-core/src/it/java/org/apache/phoenix/end2end/End2EndTestDriver.java
+++ b/phoenix-core/src/it/java/org/apache/phoenix/end2end/End2EndTestDriver.java
@@ -25,6 +25,7 @@ import java.util.HashSet;
import java.util.List;
import java.util.Set;
import java.util.regex.Pattern;
+import java.util.regex.PatternSyntaxException;
import org.apache.commons.cli.CommandLine;
import org.apache.hadoop.hbase.ClassFinder;
@@ -38,6 +39,8 @@ import org.junit.runner.Description;
import org.junit.runner.JUnitCore;
import org.junit.runner.Result;
import org.junit.runner.notification.Failure;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/**
* This class drives the End2End tests suite execution against an
@@ -45,6 +48,7 @@ import org.junit.runner.notification.Failure;
*/
public class End2EndTestDriver extends AbstractHBaseTool {
+ private static final Logger LOG = LoggerFactory.getLogger(End2EndTestDriver.class);
private static final String SHORT_REGEX_ARG = "r";
private static final String SKIP_TESTS = "n";
@@ -73,7 +77,13 @@ public class End2EndTestDriver extends AbstractHBaseTool {
}
public void setPattern(String pattern) {
- testFilterRe = Pattern.compile(pattern);
+ try {
+ testFilterRe = Pattern.compile(pattern);
+ } catch (PatternSyntaxException e) {
+ LOG.error("Failed to find tests using pattern '" + pattern
+ + "'. Is it a valid Java regular expression?", e);
+ throw e;
+ }
}
@Override
[6/6] phoenix git commit: PHOENIX-3565 Set failIfNoTests=false on
surefire and failsafe
Posted by el...@apache.org.
PHOENIX-3565 Set failIfNoTests=false on surefire and failsafe
Project: http://git-wip-us.apache.org/repos/asf/phoenix/repo
Commit: http://git-wip-us.apache.org/repos/asf/phoenix/commit/91d1478c
Tree: http://git-wip-us.apache.org/repos/asf/phoenix/tree/91d1478c
Diff: http://git-wip-us.apache.org/repos/asf/phoenix/diff/91d1478c
Branch: refs/heads/4.x-HBase-0.98
Commit: 91d1478cf00899d8016507310885bcb269bd32ee
Parents: fc6643a
Author: Josh Elser <el...@apache.org>
Authored: Thu Jan 5 12:48:21 2017 -0500
Committer: Josh Elser <el...@apache.org>
Committed: Thu Jan 5 23:56:31 2017 -0500
----------------------------------------------------------------------
pom.xml | 2 ++
1 file changed, 2 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/phoenix/blob/91d1478c/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index 6cee634..daabe08 100644
--- a/pom.xml
+++ b/pom.xml
@@ -119,6 +119,8 @@
<!-- Plugin options -->
<numForkedUT>5</numForkedUT>
<numForkedIT>5</numForkedIT>
+ <it.failIfNoSpecifiedTests>false</it.failIfNoSpecifiedTests>
+ <surefire.failIfNoSpecifiedTests>false</surefire.failIfNoSpecifiedTests>
<!-- Set default encoding so multi-byte tests work correctly on the Mac -->
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
[3/6] phoenix git commit: PHOENIX-3557 Provide a good error message
when an invalid test pattern was provided
Posted by el...@apache.org.
PHOENIX-3557 Provide a good error message when an invalid test pattern was provided
Project: http://git-wip-us.apache.org/repos/asf/phoenix/repo
Commit: http://git-wip-us.apache.org/repos/asf/phoenix/commit/d79943a9
Tree: http://git-wip-us.apache.org/repos/asf/phoenix/tree/d79943a9
Diff: http://git-wip-us.apache.org/repos/asf/phoenix/diff/d79943a9
Branch: refs/heads/4.x-HBase-1.1
Commit: d79943a9d19320317f76830ec67bd1d2b67b026b
Parents: 2e7a8c6
Author: Josh Elser <el...@apache.org>
Authored: Thu Jan 5 13:37:59 2017 -0500
Committer: Josh Elser <el...@apache.org>
Committed: Thu Jan 5 23:48:55 2017 -0500
----------------------------------------------------------------------
.../org/apache/phoenix/end2end/End2EndTestDriver.java | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/phoenix/blob/d79943a9/phoenix-core/src/it/java/org/apache/phoenix/end2end/End2EndTestDriver.java
----------------------------------------------------------------------
diff --git a/phoenix-core/src/it/java/org/apache/phoenix/end2end/End2EndTestDriver.java b/phoenix-core/src/it/java/org/apache/phoenix/end2end/End2EndTestDriver.java
index a505c1e..feb506f 100644
--- a/phoenix-core/src/it/java/org/apache/phoenix/end2end/End2EndTestDriver.java
+++ b/phoenix-core/src/it/java/org/apache/phoenix/end2end/End2EndTestDriver.java
@@ -25,6 +25,7 @@ import java.util.HashSet;
import java.util.List;
import java.util.Set;
import java.util.regex.Pattern;
+import java.util.regex.PatternSyntaxException;
import org.apache.commons.cli.CommandLine;
import org.apache.hadoop.hbase.ClassFinder;
@@ -38,6 +39,8 @@ import org.junit.runner.Description;
import org.junit.runner.JUnitCore;
import org.junit.runner.Result;
import org.junit.runner.notification.Failure;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/**
* This class drives the End2End tests suite execution against an
@@ -45,6 +48,7 @@ import org.junit.runner.notification.Failure;
*/
public class End2EndTestDriver extends AbstractHBaseTool {
+ private static final Logger LOG = LoggerFactory.getLogger(End2EndTestDriver.class);
private static final String SHORT_REGEX_ARG = "r";
private static final String SKIP_TESTS = "n";
@@ -73,7 +77,13 @@ public class End2EndTestDriver extends AbstractHBaseTool {
}
public void setPattern(String pattern) {
- testFilterRe = Pattern.compile(pattern);
+ try {
+ testFilterRe = Pattern.compile(pattern);
+ } catch (PatternSyntaxException e) {
+ LOG.error("Failed to find tests using pattern '" + pattern
+ + "'. Is it a valid Java regular expression?", e);
+ throw e;
+ }
}
@Override
[5/6] phoenix git commit: PHOENIX-3557 Provide a good error message
when an invalid test pattern was provided
Posted by el...@apache.org.
PHOENIX-3557 Provide a good error message when an invalid test pattern was provided
Project: http://git-wip-us.apache.org/repos/asf/phoenix/repo
Commit: http://git-wip-us.apache.org/repos/asf/phoenix/commit/fc6643a4
Tree: http://git-wip-us.apache.org/repos/asf/phoenix/tree/fc6643a4
Diff: http://git-wip-us.apache.org/repos/asf/phoenix/diff/fc6643a4
Branch: refs/heads/4.x-HBase-0.98
Commit: fc6643a42ff690065f7d8606098f2656e531558a
Parents: 8ba67b3
Author: Josh Elser <el...@apache.org>
Authored: Thu Jan 5 13:37:59 2017 -0500
Committer: Josh Elser <el...@apache.org>
Committed: Thu Jan 5 23:56:18 2017 -0500
----------------------------------------------------------------------
.../org/apache/phoenix/end2end/End2EndTestDriver.java | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/phoenix/blob/fc6643a4/phoenix-core/src/it/java/org/apache/phoenix/end2end/End2EndTestDriver.java
----------------------------------------------------------------------
diff --git a/phoenix-core/src/it/java/org/apache/phoenix/end2end/End2EndTestDriver.java b/phoenix-core/src/it/java/org/apache/phoenix/end2end/End2EndTestDriver.java
index a505c1e..feb506f 100644
--- a/phoenix-core/src/it/java/org/apache/phoenix/end2end/End2EndTestDriver.java
+++ b/phoenix-core/src/it/java/org/apache/phoenix/end2end/End2EndTestDriver.java
@@ -25,6 +25,7 @@ import java.util.HashSet;
import java.util.List;
import java.util.Set;
import java.util.regex.Pattern;
+import java.util.regex.PatternSyntaxException;
import org.apache.commons.cli.CommandLine;
import org.apache.hadoop.hbase.ClassFinder;
@@ -38,6 +39,8 @@ import org.junit.runner.Description;
import org.junit.runner.JUnitCore;
import org.junit.runner.Result;
import org.junit.runner.notification.Failure;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/**
* This class drives the End2End tests suite execution against an
@@ -45,6 +48,7 @@ import org.junit.runner.notification.Failure;
*/
public class End2EndTestDriver extends AbstractHBaseTool {
+ private static final Logger LOG = LoggerFactory.getLogger(End2EndTestDriver.class);
private static final String SHORT_REGEX_ARG = "r";
private static final String SKIP_TESTS = "n";
@@ -73,7 +77,13 @@ public class End2EndTestDriver extends AbstractHBaseTool {
}
public void setPattern(String pattern) {
- testFilterRe = Pattern.compile(pattern);
+ try {
+ testFilterRe = Pattern.compile(pattern);
+ } catch (PatternSyntaxException e) {
+ LOG.error("Failed to find tests using pattern '" + pattern
+ + "'. Is it a valid Java regular expression?", e);
+ throw e;
+ }
}
@Override
[4/6] phoenix git commit: PHOENIX-3565 Set failIfNoTests=false on
surefire and failsafe
Posted by el...@apache.org.
PHOENIX-3565 Set failIfNoTests=false on surefire and failsafe
Project: http://git-wip-us.apache.org/repos/asf/phoenix/repo
Commit: http://git-wip-us.apache.org/repos/asf/phoenix/commit/e24ec6a8
Tree: http://git-wip-us.apache.org/repos/asf/phoenix/tree/e24ec6a8
Diff: http://git-wip-us.apache.org/repos/asf/phoenix/diff/e24ec6a8
Branch: refs/heads/4.x-HBase-1.1
Commit: e24ec6a8eeceab8358f2cc2d2bcfba9f18571c13
Parents: d79943a
Author: Josh Elser <el...@apache.org>
Authored: Thu Jan 5 12:48:21 2017 -0500
Committer: Josh Elser <el...@apache.org>
Committed: Thu Jan 5 23:49:16 2017 -0500
----------------------------------------------------------------------
pom.xml | 2 ++
1 file changed, 2 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/phoenix/blob/e24ec6a8/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index 7978a81..7a82e32 100644
--- a/pom.xml
+++ b/pom.xml
@@ -119,6 +119,8 @@
<!-- Plugin options -->
<numForkedUT>6</numForkedUT>
<numForkedIT>6</numForkedIT>
+ <it.failIfNoSpecifiedTests>false</it.failIfNoSpecifiedTests>
+ <surefire.failIfNoSpecifiedTests>false</surefire.failIfNoSpecifiedTests>
<!-- Set default encoding so multi-byte tests work correctly on the Mac -->
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
[2/6] phoenix git commit: PHOENIX-3565 Set failIfNoTests=false on
surefire and failsafe
Posted by el...@apache.org.
PHOENIX-3565 Set failIfNoTests=false on surefire and failsafe
Project: http://git-wip-us.apache.org/repos/asf/phoenix/repo
Commit: http://git-wip-us.apache.org/repos/asf/phoenix/commit/a164f032
Tree: http://git-wip-us.apache.org/repos/asf/phoenix/tree/a164f032
Diff: http://git-wip-us.apache.org/repos/asf/phoenix/diff/a164f032
Branch: refs/heads/master
Commit: a164f0327e568a515ce9da2f5760c57a4d4dd188
Parents: e4c6f5c
Author: Josh Elser <el...@apache.org>
Authored: Thu Jan 5 12:48:21 2017 -0500
Committer: Josh Elser <el...@apache.org>
Committed: Thu Jan 5 22:19:35 2017 -0500
----------------------------------------------------------------------
pom.xml | 2 ++
1 file changed, 2 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/phoenix/blob/a164f032/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index 4a0292d..d47a6b8 100644
--- a/pom.xml
+++ b/pom.xml
@@ -119,6 +119,8 @@
<!-- Plugin options -->
<numForkedUT>8</numForkedUT>
<numForkedIT>8</numForkedIT>
+ <it.failIfNoSpecifiedTests>false</it.failIfNoSpecifiedTests>
+ <surefire.failIfNoSpecifiedTests>false</surefire.failIfNoSpecifiedTests>
<!-- Set default encoding so multi-byte tests work correctly on the Mac -->
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>