[GitHub] [couchdb] kocolosk opened a new pull request #2206: Include search in the list of advertised features

[GitBox <gi...@apache.org>]

kocolosk opened a new pull request #2206: Include search in the list of advertised features
URL: https://github.com/apache/couchdb/pull/2206
 
 
   ## Overview
   
   The reason we don't do this in `config:features()` directly is because this one is a dynamic check for the presence of a connected clouseau node. Calling `enable_feature` every time we conduct that check seemed too heavyweight, but I didn't see a good opportunity to just call it once and be confident that it would reliably advertise the feature.
   
   The downside here is that CouchDB will not advertise the "search" feature if Clouseau is disconnected for maintenance or whatever, although technically it's accurate since search requests submitted during that interval would fail.
   
   ## Testing recommendations
   
   Wire up CouchDB with Clouseau and see if "search" shows up in the list of features.
   
   ## Related Issues or Pull Requests
   
   #2205 
   
   ## Checklist
   
   - [x] Code is written and works correctly
   - [ ] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services