You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by st...@apache.org on 2009/01/24 07:59:41 UTC
svn commit: r737310 - in /hadoop/core/trunk: CHANGES.txt
src/core/org/apache/hadoop/util/bloom/HashFunction.java
Author: stack
Date: Sat Jan 24 06:59:40 2009
New Revision: 737310
URL: http://svn.apache.org/viewvc?rev=737310&view=rev
Log:
HADOOP-5079 HashFunction inadvertently destroys some randomness
Modified:
hadoop/core/trunk/CHANGES.txt
hadoop/core/trunk/src/core/org/apache/hadoop/util/bloom/HashFunction.java
Modified: hadoop/core/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/CHANGES.txt?rev=737310&r1=737309&r2=737310&view=diff
==============================================================================
--- hadoop/core/trunk/CHANGES.txt (original)
+++ hadoop/core/trunk/CHANGES.txt Sat Jan 24 06:59:40 2009
@@ -66,6 +66,10 @@
HADOOP-4975. Set classloader for nested mapred.join configs. (Jingkei Ly
via cdouglas)
+ HADOOP-5079. HashFunction inadvertently destroys some randomness
+ (Jonathan Ellis via stack)
+
+
Release 0.20.0 - Unreleased
INCOMPATIBLE CHANGES
Modified: hadoop/core/trunk/src/core/org/apache/hadoop/util/bloom/HashFunction.java
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/src/core/org/apache/hadoop/util/bloom/HashFunction.java?rev=737310&r1=737309&r2=737310&view=diff
==============================================================================
--- hadoop/core/trunk/src/core/org/apache/hadoop/util/bloom/HashFunction.java (original)
+++ hadoop/core/trunk/src/core/org/apache/hadoop/util/bloom/HashFunction.java Sat Jan 24 06:59:40 2009
@@ -111,7 +111,8 @@
}
int[] result = new int[nbHash];
for (int i = 0, initval = 0; i < nbHash; i++) {
- initval = result[i] = Math.abs(hashFunction.hash(b, initval) % maxValue);
+ initval = hashFunction.hash(b, initval);
+ result[i] = Math.abs(initval) % maxValue;
}
return result;
}