You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/04 20:37:40 UTC
[GitHub] [superset] ChristopherCFleming opened a new pull request, #19523: refactor(DataSourceEditor): Update with TypeScript
ChristopherCFleming opened a new pull request, #19523:
URL: https://github.com/apache/superset/pull/19523
### SUMMARY
Added TypeScript to all component props except for the last component in DataSourceEditor. Removed the PropTypes and placed them before the components for easier readibility.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] refactor(DataSourceEditor): Update with TypeScript [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #19523:
URL: https://github.com/apache/superset/pull/19523#issuecomment-1930684606
Closing this since it doesn't seem like it'll get rebased and carried across the finish line. Pinging @justinpark in case we want to rekindle some of this on a fresh PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #19523: refactor(DataSourceEditor): Update with TypeScript
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #19523:
URL: https://github.com/apache/superset/pull/19523#issuecomment-1399825263
@ChristopherCFleming sorry this didn't get much attention before! I've added a couple reviewers, but would you be able/willing to give this a rebase? A lot of modifications have happened in this area, so I'm hopeful it's not a painful rebase 🤞. Thank you for contributing this, in any case. We need a LOT more Typescript conversion help around here!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] refactor(DataSourceEditor): Update with TypeScript [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #19523: refactor(DataSourceEditor): Update with TypeScript
URL: https://github.com/apache/superset/pull/19523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org