[GitHub] [geode] dschneider-pivotal opened pull request #4820: GEODE-7826: start jmx-manager if the Geode Management Rest Service is enabled

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

Before the geode management rest service web app is added,
the code now starts the jmx-manager. If it can not be started then
an error will be reported.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/4820 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] demery-pivotal commented on pull request #4820: GEODE-7826: start jmx-manager if the Geode Management Rest Service is enabled

["demery-pivotal (GitHub)" <gi...@apache.org>]

I think most of the common setup stuff could be moved into a setup method. Then only the stuff that differs from one test to another would remain. That would make the test-specific details stand out more, and would more clearly express the intent of each test.

If only a few setup details remain in each test, and the intent is obvious, that's enough. If there are more than a few details, perhaps they can be hidden in helper methods with that express the intent.

[ Full content available at: https://github.com/apache/geode/pull/4820 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #4820: GEODE-7826: start jmx-manager if the Geode Management Rest Service is enabled

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

added a comment

[ Full content available at: https://github.com/apache/geode/pull/4820 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] demery-pivotal commented on pull request #4820: GEODE-7826: start jmx-manager if the Geode Management Rest Service is enabled

["demery-pivotal (GitHub)" <gi...@apache.org>]

Instead of adding a new test-only method, try this:
- Add a new `Supplier<InternalCache>` parameter to the `InternalLocator` constructor, and let the constructor store the supplier in a field for later use.
- Change `InternalLocator.getCache()` to call the supplier instead of calling `GemFireCacheImpl.getInstance()` directly.
- Change `InternalLocator.createLocator(…)` and `InternalLocatorIntegrationTest` to pass `GemFireCacheImpl::getInstance` to the `InternalLocator` constructor.
- In these new tests, pass the mock cache to the `InternalLocator` constructor.

[ Full content available at: https://github.com/apache/geode/pull/4820 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on pull request #4820: GEODE-7826: start jmx-manager if the Geode Management Rest Service is enabled

["jinmeiliao (GitHub)" <gi...@apache.org>]

Maybe put a comment here stating why jmxManager is needed when starting management rest service


[ Full content available at: https://github.com/apache/geode/pull/4820 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org