You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/01/16 18:43:35 UTC
[GitHub] [couchdb] wohali opened a new pull request #2463: Fix ini file
setting for #2296
wohali opened a new pull request #2463: Fix ini file setting for #2296
URL: https://github.com/apache/couchdb/pull/2463
Settings in `default.ini` should be the defaults. Also a little text cleanup for clarity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] wohali merged pull request #2463: Fix ini file setting
for #2296
Posted by GitBox <gi...@apache.org>.
wohali merged pull request #2463: Fix ini file setting for #2296
URL: https://github.com/apache/couchdb/pull/2463
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] wohali commented on a change in pull request #2463: Fix
ini file setting for #2296
Posted by GitBox <gi...@apache.org>.
wohali commented on a change in pull request #2463: Fix ini file setting for #2296
URL: https://github.com/apache/couchdb/pull/2463#discussion_r370971645
##########
File path: rel/overlay/etc/default.ini
##########
@@ -69,8 +69,9 @@ default_engine = couch
; is 10GiB. A value of 0 or less will disable partition size checks.
;max_partition_size = 10737418240
;
-; Start node in single_node mode so default databases are created immediately.
-;single_node = true
+; When true, system databases _users and _replicator are created immediately
Review comment:
@janl do you want to remove `_global_changes` from the setup wizard for 3.0.0?
let me know and we can decide if we fix the message here, or `src/setup/erl/setup.src`. I can see an argument both ways.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] wohali commented on a change in pull request #2463: Fix
ini file setting for #2296
Posted by GitBox <gi...@apache.org>.
wohali commented on a change in pull request #2463: Fix ini file setting for #2296
URL: https://github.com/apache/couchdb/pull/2463#discussion_r372020311
##########
File path: rel/overlay/etc/default.ini
##########
@@ -69,8 +69,9 @@ default_engine = couch
; is 10GiB. A value of 0 or less will disable partition size checks.
;max_partition_size = 10737418240
;
-; Start node in single_node mode so default databases are created immediately.
-;single_node = true
+; When true, system databases _users and _replicator are created immediately
Review comment:
Have moved this change out to another PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] willholley commented on a change in pull request #2463:
Fix ini file setting for #2296
Posted by GitBox <gi...@apache.org>.
willholley commented on a change in pull request #2463: Fix ini file setting for #2296
URL: https://github.com/apache/couchdb/pull/2463#discussion_r369483153
##########
File path: rel/overlay/etc/default.ini
##########
@@ -69,8 +69,9 @@ default_engine = couch
; is 10GiB. A value of 0 or less will disable partition size checks.
;max_partition_size = 10737418240
;
-; Start node in single_node mode so default databases are created immediately.
-;single_node = true
+; When true, system databases _users and _replicator are created immediately
Review comment:
minor nit - `_global_changes` is also counted as a system database (perhaps questionably) so will get created automatically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services