You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by khalidhuseynov <gi...@git.apache.org> on 2016/11/24 10:02:05 UTC
[GitHub] zeppelin pull request #1675: [ZEPPELIN-1190] [WIP] Visit and switch notebook...
GitHub user khalidhuseynov opened a pull request:
https://github.com/apache/zeppelin/pull/1675
[ZEPPELIN-1190] [WIP] Visit and switch notebook revisions
### What is this PR for?
This is the last step for enabling Zeppelin to work with revisions. It addresses ability to visit certain revision, switch among them, and reset to certain revision. Note that initial work started from #1304 and manually moved commits due to conflicts in `cherry-pick`. Currently WIP.
### What type of PR is it?
Improvement | Feature
### Todos
* [ ] - Task
### What is the Jira issue?
[ZEPPELIN-1190](https://issues.apache.org/jira/browse/ZEPPELIN-1190)
### How should this be tested?
set config in conf/zeppelin-env.sh
```
export ZEPPELIN_NOTEBOOK_STORAGE="org.apache.zeppelin.notebook.repo.GitNotebookRepo"
```
and switch between notes in note action bar
### Screenshots (if appropriate)
TBD
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin feat/switch-revisions
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1675.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1675
----
commit 37f8100f7765aef8cbd2bb8ccbf360d4eef806ce
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-24T04:59:42Z
create new root and call revision
commit e3fdecd3cf33a23d1f65305cdab1d4a1f2d9fd8f
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-24T05:55:18Z
load revision note
commit 2858d273ee221422697d58ff4b8bdb7468fa445a
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-24T06:19:56Z
visit revision when click in dropdown
commit 111a7daad5d60985de65460f4627385cd2dc9e73
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-24T06:44:12Z
set current revision name
commit d2c1be313781fa3fe7da02a565521f651df3cc06
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-24T07:16:25Z
fix quotes
commit 3804e07443eb2cfd5db2b0ddd5aadb271c47a318
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-24T09:49:32Z
fix getNote name change
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1675: [ZEPPELIN-1190] Visit and switch notebook revis...
Posted by khalidhuseynov <gi...@git.apache.org>.
GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/1675
[ZEPPELIN-1190] Visit and switch notebook revisions
### What is this PR for?
This is to enable switching between revisions and being able to set `Head`/current note to one of those revisions. Currently notes are editable when switching between them, next step after this PR would be make them non-editable during revision switches.
### What type of PR is it?
Improvement | Feature
### Todos
* [x] - routes and switching revisions
* [x] - set revision button and api
* [x] - test for setting revision
### What is the Jira issue?
[ZEPPELIN-1190](https://issues.apache.org/jira/browse/ZEPPELIN-1190)
### How should this be tested?
set config in conf/zeppelin-env.sh
```
export ZEPPELIN_NOTEBOOK_STORAGE="org.apache.zeppelin.notebook.repo.GitNotebookRepo"
```
and switch between notes in note action bar, as well as set certain revisions as shown below
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin feat/switch-revisions
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1675.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1675
----
commit 268fb4fbe33afaadb61879fe402d8a143c664db9
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-24T04:59:42Z
create new root and call revision
commit ab103381571e6743ec3ae53011e38ef94aeb8449
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-24T05:55:18Z
load revision note
commit a73214238d07f06b2f6f68fb2153c794725ba9ac
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-24T06:19:56Z
visit revision when click in dropdown
commit d2d5396a71cddae00a422d80e2126785816e86e2
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-24T06:44:12Z
set current revision name
commit 992a00f875c372da4ca807b0743925d09a907c7b
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-24T07:16:25Z
fix quotes
commit 7f7b382d01a4d9f635cd25ff72346435a566a598
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-24T09:49:32Z
fix getNote name change
commit 50469ca8c0c177c49fe63472e48d6bb38d7ce647
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-25T08:29:33Z
fix pass data
commit 50c7a58b57b74ddfd421f315ac43ed0cb97bd93f
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-27T11:02:57Z
fix parameters
commit 8d14981ffca40bd9ad19b4ecc7ee801c21e12591
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-30T03:58:30Z
add set revision button
commit 7c1e300b61bb7842090db035a240ec93517d92ef
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-30T04:46:34Z
add ws api on front
commit c7b4e73b98f7eebb0ff37793c5b7a801444632a2
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-30T09:03:19Z
add backend api for setting revision
commit ae2cdcf6ce95d383b849f5d13384ecca0865be93
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-30T16:44:40Z
go to note after setting revision
commit f36dc5db2f7a35d765d1d3f2786ae7ae443a69dd
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-01T04:12:47Z
fix log and checkstyle
commit 934fb6bc62b01198f7758392f4c9bc8536c91e37
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-01T05:19:47Z
add writer permission check
commit feb858dac287151391627a2629d02b36b9f12b13
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-01T09:27:46Z
return result status and reload to head if ok
commit 692c6c13aa708ee19edaf3d5e215886f6646ff74
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-01T09:37:44Z
show error message popup if couldn't set revision
commit c474ba854b23ee368c422a64139f0de852c8ca49
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-02T09:48:18Z
add test
commit d17796bd83d95197c27bc22368fc8642dd4048ad
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-02T10:12:24Z
add broadcast
commit 506fea08b458f44d69ccf7cbf77c39f3fb25192f
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-02T11:59:32Z
add disable flag for setting revision
only when enabled when in certain revision
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1675: [ZEPPELIN-1190] Visit and switch notebook revisions
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1675
LGTM and merge to master if there're no further discussions.
@khalidhuseynov Great work!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1675: [ZEPPELIN-1190] Visit and switch notebook revis...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/1675
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1675: [ZEPPELIN-1190] Visit and switch notebook revis...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1675
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1675: [ZEPPELIN-1190] Visit and switch notebook revisions
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1675
not sure why only one profile keeps failing with all rest api tests, and profile itself have `-DskipTests` flag
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1675: [ZEPPELIN-1190] [WIP] Visit and switch notebook...
Posted by khalidhuseynov <gi...@git.apache.org>.
GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/1675
[ZEPPELIN-1190] [WIP] Visit and switch notebook revisions
### What is this PR for?
This is the last step for enabling Zeppelin to work with revisions. It addresses ability to visit certain revision, switch among them, and reset to certain revision. Note that initial work started from #1304 and manually moved commits due to conflicts in `cherry-pick`. Currently WIP.
### What type of PR is it?
Improvement | Feature
### Todos
* [ ] - Task
### What is the Jira issue?
[ZEPPELIN-1190](https://issues.apache.org/jira/browse/ZEPPELIN-1190)
### How should this be tested?
set config in conf/zeppelin-env.sh
```
export ZEPPELIN_NOTEBOOK_STORAGE="org.apache.zeppelin.notebook.repo.GitNotebookRepo"
```
and switch between notes in note action bar
### Screenshots (if appropriate)
TBD
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin feat/switch-revisions
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1675.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1675
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1675: [ZEPPELIN-1190] Visit and switch notebook revis...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/1675
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1675: [ZEPPELIN-1190] Visit and switch notebook revisions
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1675
Tested and it works well. Great work @khalidhuseynov.
But when i visit revision, shouldn't it be immutable? i can still edit and run.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1675: [ZEPPELIN-1190] Visit and switch notebook revisions
Posted by anthonycorbacho <gi...@git.apache.org>.
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1675
LGTM thank for the contrib
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1675: [ZEPPELIN-1190] Visit and switch notebook revisions
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1675
rebased from master, and 6th profile keeps failing with Zeppelin shutting down because of no `SPARK_HOME`. So initially fails to untar spark package:
```
+mkdir -p .spark-dist
+cd .spark-dist
+[[ ! -f spark-1.4.1-bin-hadoop2.3.tgz ]]
+cp spark-1.4.1-bin-hadoop2.3.tgz ..
+cd ..
+tar zxf spark-1.4.1-bin-hadoop2.3.tgz
gzip: stdin: unexpected end of file
tar: Unexpected EOF in archive
tar: Unexpected EOF in archive
tar: Error is not recoverable: exiting now
+echo 'Unable to extract spark-1.4.1-bin-hadoop2.3.tgz'
Unable to extract spark-1.4.1-bin-hadoop2.3.tgz
+rm -rf spark-1.4.1-bin-hadoop2.3
+rm -f spark-1.4.1-bin-hadoop2.3.tgz
+set +xe
```
and then in tests:
```
02:22:06,298 INFO org.apache.zeppelin.rest.AbstractTestRestApi:181 - Test Zeppelin stared.
SPARK HOME detected null
02:22:06,302 INFO org.apache.zeppelin.rest.AbstractTestRestApi:298 - Terminating test Zeppelin...
```
which fails all rest api tests. obviously this is not related to this PR, although not sure why spark untar keeps failing in same profile. logs are [here](https://api.travis-ci.org/jobs/181537712/log.txt?deansi=true).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1675: [ZEPPELIN-1190] Visit and switch notebook revis...
Posted by khalidhuseynov <gi...@git.apache.org>.
GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/1675
[ZEPPELIN-1190] Visit and switch notebook revisions
### What is this PR for?
This is to enable switching between revisions and being able to set `Head`/current note to one of those revisions. Currently notes are editable when switching between them, next step after this PR would be make them non-editable during revision switches.
### What type of PR is it?
Improvement | Feature
### Todos
* [x] - routes and switching revisions
* [x] - set revision button and api
* [x] - test for setting revision
### What is the Jira issue?
[ZEPPELIN-1190](https://issues.apache.org/jira/browse/ZEPPELIN-1190)
### How should this be tested?
set config in conf/zeppelin-env.sh
```
export ZEPPELIN_NOTEBOOK_STORAGE="org.apache.zeppelin.notebook.repo.GitNotebookRepo"
```
and switch between notes in note action bar, as well as set certain revisions as shown below
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin feat/switch-revisions
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1675.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1675
----
commit 9f1c59284dd45f62fb4d984b86936a7584f68759
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-24T04:59:42Z
create new root and call revision
commit 510b59ef5c2219a7b7f5f16ddf9ce0dd14f05d4f
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-24T05:55:18Z
load revision note
commit d89fdefd8cfd073f773c50633036bc845091f04b
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-24T06:19:56Z
visit revision when click in dropdown
commit abd666f4f25b1596f60734db8f4cc1e0b59b574d
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-24T06:44:12Z
set current revision name
commit ff3dba590766dbbc20cd767041f24db4f6fb7b4e
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-24T07:16:25Z
fix quotes
commit 060eb3acb7d9b96101cad58600607ca55d16038d
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-24T09:49:32Z
fix getNote name change
commit c7ee3a3d6aadc8e142a2ecbf2729c6df370ea024
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-25T08:29:33Z
fix pass data
commit f4477ecf7e9b6045c58181361b5adaad74f1b3fa
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-27T11:02:57Z
fix parameters
commit 8d7730f85336367b1ca00469674c3456762623af
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-30T03:58:30Z
add set revision button
commit 87a801b829ecf16709093997e2bf9d0b7a987403
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-30T04:46:34Z
add ws api on front
commit 3a1fc372ba131a008d373d7d4a76c0dae63f0b55
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-30T09:03:19Z
add backend api for setting revision
commit 655b831c586abd8c7f4c18e2dc13e550fac89bb5
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-30T16:44:40Z
go to note after setting revision
commit 8a7cdf1be629f652887672fca2970b2828adb997
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-01T04:12:47Z
fix log and checkstyle
commit bd72d3216394755f04578a28b2bac3f52c6c50e0
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-01T05:19:47Z
add writer permission check
commit d93aebac977ba323431c4dd7d6d8d2de4ad81f65
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-01T09:27:46Z
return result status and reload to head if ok
commit 3998a8962a69779ea1421c7742d67c62bfc2dfb1
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-01T09:37:44Z
show error message popup if couldn't set revision
commit b47331880e696ba3f3d761db5951a1a27e392550
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-02T09:48:18Z
add test
commit b233dec350bb761bdb49324e579fa204c4a66503
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-02T10:12:24Z
add broadcast
commit 25ccf8f49aef899cf35f6f31667e4f02d210cf1c
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-02T11:59:32Z
add disable flag for setting revision
only when enabled when in certain revision
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1675: [ZEPPELIN-1190] Visit and switch notebook revisions
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1675
@Leemoonsoo yes right currently it's editable and runnable, which is updated in PR description. Actually I want to add additional `offline` or `report-offline` mode and basically switch to that mode when viewing revisions. I think that's quite separate issue from this one and can be addressed right after this one, what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1675: [ZEPPELIN-1190] [WIP] Visit and switch notebook...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/1675
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1675: [ZEPPELIN-1190] Visit and switch notebook revis...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/1675
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1675: [ZEPPELIN-1190] Visit and switch notebook revisions
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1675
this is ready for review. @Leemoonsoo let me know if you have any feedback regarding this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1675: [ZEPPELIN-1190] Visit and switch notebook revisions
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1675
created issue under [ZEPPELIN-1745](https://issues.apache.org/jira/browse/ZEPPELIN-1745) for second part
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1675: [ZEPPELIN-1190] Visit and switch notebook revis...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/1675
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1675: [ZEPPELIN-1190] Visit and switch notebook revisions
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1675
@khalidhuseynov sounds good.
Let's wait for CI becomes green. Other than that, Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1675: [ZEPPELIN-1190] Visit and switch notebook revis...
Posted by khalidhuseynov <gi...@git.apache.org>.
GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/1675
[ZEPPELIN-1190] Visit and switch notebook revisions
### What is this PR for?
This is to enable switching between revisions and being able to set `Head`/current note to one of those revisions. Currently notes are editable when switching between them, next step after this PR would be make them non-editable during revision switches.
### What type of PR is it?
Improvement | Feature
### Todos
* [x] - routes and switching revisions
* [x] - set revision button and api
* [x] - test for setting revision
### What is the Jira issue?
[ZEPPELIN-1190](https://issues.apache.org/jira/browse/ZEPPELIN-1190)
### How should this be tested?
set config in conf/zeppelin-env.sh
```
export ZEPPELIN_NOTEBOOK_STORAGE="org.apache.zeppelin.notebook.repo.GitNotebookRepo"
```
and switch between notes in note action bar, as well as set certain revisions as shown below
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin feat/switch-revisions
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1675.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1675
----
commit d1a16e0c6aa226dac4429f0c25b5152ad83b77f8
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-24T04:59:42Z
create new root and call revision
commit e78add69f41a33619eb1597f4fa09834b7f7070d
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-24T05:55:18Z
load revision note
commit 105f609801fa9f5a11a116d4dee2baa335f20370
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-24T06:19:56Z
visit revision when click in dropdown
commit de1cc005537f41983c794dfd7564bc25b39a1c1f
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-24T06:44:12Z
set current revision name
commit f54f2e82984ca746a92f64c0dc5bcc26d806c937
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-24T07:16:25Z
fix quotes
commit dd4d2d9691df119172a0fd038e8a5e86974cce93
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-24T09:49:32Z
fix getNote name change
commit 3f508d470d73afe9e8963d23d34938ed29e2e6f6
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-25T08:29:33Z
fix pass data
commit 9628d64391aec9bceb914af8436a29464a39b679
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-27T11:02:57Z
fix parameters
commit bc15533a39668271aa6604e8ff6ea22afb3cbff9
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-30T03:58:30Z
add set revision button
commit 30a2ebc25b5dd6902cef30bcbb143d74ae83d1c3
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-30T04:46:34Z
add ws api on front
commit a657ab5cf18fdece113ad77844135a5afb6ab6ef
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-30T09:03:19Z
add backend api for setting revision
commit a05a335a2c7d063d286a477eb1f1747d5637db78
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-30T16:44:40Z
go to note after setting revision
commit b6a0ba2f56535933d4bbd28fda281752e261b8c6
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-01T04:12:47Z
fix log and checkstyle
commit fae51cb26a556519560d087dff15686ae407159a
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-01T05:19:47Z
add writer permission check
commit 989c5df1c56a8e3c3cc61663f4414470bfac09b3
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-01T09:27:46Z
return result status and reload to head if ok
commit 737ce15bd9cd3a2db408f0764cd4012be5874a64
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-01T09:37:44Z
show error message popup if couldn't set revision
commit c70a20069f8cd70ce97a77a80e4f945b01d60e38
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-02T09:48:18Z
add test
commit f4f9dcc762a342f47cc932cf2be0e716126d1ef2
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-02T10:12:24Z
add broadcast
commit ab7db290eb1e701fb9e01e28f4f5d8a33ce2d0e0
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-02T11:59:32Z
add disable flag for setting revision
only when enabled when in certain revision
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1675: [ZEPPELIN-1190] Visit and switch notebook revisions
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1675
@Leemoonsoo CI is finally green, I think it's ready to go
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---