[GitHub] [superset] nytai commented on a change in pull request #13286: test: Tests for DeleteModal component

[GitBox <gi...@apache.org>]

nytai commented on a change in pull request #13286:
URL: https://github.com/apache/superset/pull/13286#discussion_r580505220



##########
File path: superset-frontend/src/components/DeleteModal/index.tsx
##########
@@ -70,8 +70,9 @@ export default function DeleteModal({
         </FormLabel>
         <FormControl
           data-test="delete-modal-input"
-          id="delete"
+          data-test-id="delete-modal-input"

Review comment:
       Superset already has a lot of these attrs as `data-test` (currently used for cypress e2e testing). Should we configure RTL to use this attr instead, so we don't end up with a bunch of duplicated attrs? 
   
   We would just have to change this line, doesn't look like there are any other instances of `data-test-id` 
   https://github.com/apache/superset/blob/a646914493c7bad943fcccf1985c6ee2d4d88269/superset-frontend/spec/helpers/setup.ts#L24




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org