[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #10658: [Feature][Task Plugin] Enable users to create python env from requirements.txt

[GitBox <gi...@apache.org>]

EricGao888 commented on code in PR #10658:
URL: https://github.com/apache/dolphinscheduler/pull/10658#discussion_r910229422


##########
dolphinscheduler-task-plugin/dolphinscheduler-task-jupyter/src/main/java/org/apache/dolphinscheduler/plugin/task/jupyter/JupyterTask.java:
##########
@@ -104,12 +102,15 @@ protected String buildCommand() throws IOException {
          */
         List<String> args = new ArrayList<>();
         final String condaPath = PropertyUtils.getString(TaskConstants.CONDA_PATH);
+        final String timestamp = DateUtils.getTimestampString();
         args.add(JupyterConstants.CONDA_INIT);
         args.add(condaPath);
         args.add(JupyterConstants.JOINTER);
         String condaEnvName = jupyterParameters.getCondaEnvName();
         if (condaEnvName.endsWith(JupyterConstants.TAR_SUFFIX)) {
             args.add(String.format(JupyterConstants.CREATE_ENV_FROM_TAR, condaEnvName));
+        } else if (condaEnvName.endsWith(JupyterConstants.TXT_SUFFIX)) {

Review Comment:
   Need to tear the temporarily constructed env if task fails.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org