You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/02/24 17:35:21 UTC

[GitHub] [lucene-solr-operator] jward-bw commented on pull request #225: Fix Ingress API group for RBAC rules.

jward-bw commented on pull request #225:
URL: https://github.com/apache/lucene-solr-operator/pull/225#issuecomment-785247613


   > Great find!
   > 
   > That file is actually auto-generated via the comment tags in solrcloud-controller, and the command `make manifests`.
   > 
   > I've made the change and run the command.
   
   Aha cheers Houston. We had just pulled the previous change in and found the error. Is `make manifests` something you would usually expect to be done as part of a PR like yours, or something that we should be running before deploying?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org