You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Mahesh Bandal <ma...@gmail.com> on 2020/10/05 19:26:14 UTC
Re: Review Request 72925: RANGER-3014: fix for RANGER-2789 breaks
current functionality
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72925/
-----------------------------------------------------------
(Updated Oct. 5, 2020, 7:26 p.m.)
Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-3014
https://issues.apache.org/jira/browse/RANGER-3014
Repository: ranger
Description
-------
Loaded 50,000 users and 500,000 group-users mapping data into database.
Following are issues caused due to RANGER-2789 :
1. It took significantly longer time to load users tab on RANGER UI, but Ranger responded within a minute with default pageSize=25.
2. User lookup in permission tab breaks current functionality. In this case ranger service crashes after couple of minutes when in edit permission tab of User/Group module, multiple requests will be sent on keyPressEvent for user search. With this patch ranger is pulling all users from the DB regardless of pageLimit. It traverse over all users and also traversing the whole group_users mapping which hampers performance.
3. Permission tab takes longer time to load UI.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/entity/XXUser.java 14f0b6439
security-admin/src/main/java/org/apache/ranger/service/XUserService.java 4b0c7e33d
security-admin/src/main/java/org/apache/ranger/service/XUserServiceBase.java 4fcdda2af
security-admin/src/main/java/org/apache/ranger/view/VXUser.java d6f53fd88
Diff: https://reviews.apache.org/r/72925/diff/1/
Testing
-------
Reverted patch of RANGER-2789, and ranger works smoothly. Users tab on RANGER UI loads in milliseconds with default pageSize=25. I also tried with pageSize=1000 and it took 22 seconds to load UI. User lookup in permission tab also responded quickly.
Thanks,
Mahesh Bandal
Re: Review Request 72925: RANGER-3014: fix for RANGER-2789 breaks
current functionality
Posted by Sailaja Polavarapu <sp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72925/#review221993
-----------------------------------------------------------
Ship it!
Ship It!
- Sailaja Polavarapu
On Oct. 5, 2020, 7:26 p.m., Mahesh Bandal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72925/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2020, 7:26 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3014
> https://issues.apache.org/jira/browse/RANGER-3014
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Loaded 50,000 users and 500,000 group-users mapping data into database.
> Following are issues caused due to RANGER-2789 :
> 1. It took significantly longer time to load users tab on RANGER UI, but Ranger responded within a minute with default pageSize=25.
> 2. User lookup in permission tab breaks current functionality. In this case ranger service crashes after couple of minutes when in edit permission tab of User/Group module, multiple requests will be sent on keyPressEvent for user search. With this patch ranger is pulling all users from the DB regardless of pageLimit. It traverse over all users and also traversing the whole group_users mapping which hampers performance.
> 3. Permission tab takes longer time to load UI.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/entity/XXUser.java 14f0b6439
> security-admin/src/main/java/org/apache/ranger/service/XUserService.java 4b0c7e33d
> security-admin/src/main/java/org/apache/ranger/service/XUserServiceBase.java 4fcdda2af
> security-admin/src/main/java/org/apache/ranger/view/VXUser.java d6f53fd88
>
>
> Diff: https://reviews.apache.org/r/72925/diff/1/
>
>
> Testing
> -------
>
> Reverted patch of RANGER-2789, and ranger works smoothly. Users tab on RANGER UI loads in milliseconds with default pageSize=25. I also tried with pageSize=1000 and it took 22 seconds to load UI. User lookup in permission tab also responded quickly.
>
>
> Thanks,
>
> Mahesh Bandal
>
>
Re: Review Request 72925: RANGER-3014: fix for RANGER-2789 breaks
current functionality
Posted by Mehul Parikh <xs...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72925/#review221992
-----------------------------------------------------------
Ship it!
Ship It!
- Mehul Parikh
On Oct. 5, 2020, 7:26 p.m., Mahesh Bandal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72925/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2020, 7:26 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3014
> https://issues.apache.org/jira/browse/RANGER-3014
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Loaded 50,000 users and 500,000 group-users mapping data into database.
> Following are issues caused due to RANGER-2789 :
> 1. It took significantly longer time to load users tab on RANGER UI, but Ranger responded within a minute with default pageSize=25.
> 2. User lookup in permission tab breaks current functionality. In this case ranger service crashes after couple of minutes when in edit permission tab of User/Group module, multiple requests will be sent on keyPressEvent for user search. With this patch ranger is pulling all users from the DB regardless of pageLimit. It traverse over all users and also traversing the whole group_users mapping which hampers performance.
> 3. Permission tab takes longer time to load UI.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/entity/XXUser.java 14f0b6439
> security-admin/src/main/java/org/apache/ranger/service/XUserService.java 4b0c7e33d
> security-admin/src/main/java/org/apache/ranger/service/XUserServiceBase.java 4fcdda2af
> security-admin/src/main/java/org/apache/ranger/view/VXUser.java d6f53fd88
>
>
> Diff: https://reviews.apache.org/r/72925/diff/1/
>
>
> Testing
> -------
>
> Reverted patch of RANGER-2789, and ranger works smoothly. Users tab on RANGER UI loads in milliseconds with default pageSize=25. I also tried with pageSize=1000 and it took 22 seconds to load UI. User lookup in permission tab also responded quickly.
>
>
> Thanks,
>
> Mahesh Bandal
>
>