You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Andreas Schaefer <sc...@me.com.INVALID> on 2019/06/18 05:24:49 UTC
Sling Content Package to Feature Model Maven Plugin
Hi
I just committed the first draft of the 'Sling Content Package to Feature Model Maven Plugin’ into branch feature/sling-cpconverter-maven-plugin of the sling-whiteboard project.
The IT tests should give a rough idea on how to use it and I will incorporate it into the Peregrine CMS project to have a better End-to-End test for this plugin.
For now this plugin is intended to generated a side-car FM configuration for an existing Content Package including installing it into the local Maven repo.
I am not a crack in writing Maven Plugins so this plugin for sure has it rough edges and so any feedback is appreciated.
Cheers - Andy Schaefer
Re: Sling Content Package to Feature Model Maven Plugin
Posted by Robert Munteanu <ro...@apache.org>.
Thanks Simo, that makes things clearer for me :-)
Robert
On Tue, 2019-07-02 at 19:30 +0200, Simone Tripodi wrote:
> Hi Rob,
> Andreas did a MOJO implementation which wraps the [1] implementation
> as a Maevn plugin, it is not a new implementation.
>
> Best,
> ~Simo
>
> http://people.apache.org/~simonetripodi/
> http://www.99soft.org/
>
> On Tue, Jul 2, 2019 at 12:51 PM Robert Munteanu <ro...@apache.org>
> wrote:
> > Hi Andy,
> >
> > On Mon, 2019-06-17 at 22:24 -0700, Andreas Schaefer wrote:
> > > Hi
> > >
> > > I just committed the first draft of the 'Sling Content Package to
> > > Feature Model Maven Plugin’ into branch feature/sling-
> > > cpconverter-
> > > maven-plugin of the sling-whiteboard project.
> > >
> > > tests should give a rough idea on how to use it and I will
> > > incorporate it into the Peregrine CMS project to have a better
> > > End-
> > > to-End test for this plugin.
> > >
> > > For now this plugin is intended to generated a side-car FM
> > > configuration for an existing Content Package including
> > > installing it
> > > into the local Maven repo.
> > >
> > > I am not a crack in writing Maven Plugins so this plugin for sure
> > > has
> > > it rough edges and so any feedback is appreciated.
> >
> > Nice to see you are looking into this. As a first question, I am
> > wondering what the difference between this and [1] is.
> >
> > Thanks,
> >
> > Robert
> >
> > [1]:
> > https://github.com/apache/sling-org-apache-sling-feature-cpconverter
> >
Re: Sling Content Package to Feature Model Maven Plugin
Posted by Simone Tripodi <si...@gmail.com>.
Hi Rob,
Andreas did a MOJO implementation which wraps the [1] implementation
as a Maevn plugin, it is not a new implementation.
Best,
~Simo
http://people.apache.org/~simonetripodi/
http://www.99soft.org/
On Tue, Jul 2, 2019 at 12:51 PM Robert Munteanu <ro...@apache.org> wrote:
>
> Hi Andy,
>
> On Mon, 2019-06-17 at 22:24 -0700, Andreas Schaefer wrote:
> > Hi
> >
> > I just committed the first draft of the 'Sling Content Package to
> > Feature Model Maven Plugin’ into branch feature/sling-cpconverter-
> > maven-plugin of the sling-whiteboard project.
> >
> > tests should give a rough idea on how to use it and I will
> > incorporate it into the Peregrine CMS project to have a better End-
> > to-End test for this plugin.
> >
> > For now this plugin is intended to generated a side-car FM
> > configuration for an existing Content Package including installing it
> > into the local Maven repo.
> >
> > I am not a crack in writing Maven Plugins so this plugin for sure has
> > it rough edges and so any feedback is appreciated.
>
> Nice to see you are looking into this. As a first question, I am
> wondering what the difference between this and [1] is.
>
> Thanks,
>
> Robert
>
> [1]: https://github.com/apache/sling-org-apache-sling-feature-cpconverter
>
Re: Sling Content Package to Feature Model Maven Plugin
Posted by Robert Munteanu <ro...@apache.org>.
Hi Andy,
On Mon, 2019-06-17 at 22:24 -0700, Andreas Schaefer wrote:
> Hi
>
> I just committed the first draft of the 'Sling Content Package to
> Feature Model Maven Plugin’ into branch feature/sling-cpconverter-
> maven-plugin of the sling-whiteboard project.
>
> tests should give a rough idea on how to use it and I will
> incorporate it into the Peregrine CMS project to have a better End-
> to-End test for this plugin.
>
> For now this plugin is intended to generated a side-car FM
> configuration for an existing Content Package including installing it
> into the local Maven repo.
>
> I am not a crack in writing Maven Plugins so this plugin for sure has
> it rough edges and so any feedback is appreciated.
Nice to see you are looking into this. As a first question, I am
wondering what the difference between this and [1] is.
Thanks,
Robert
[1]: https://github.com/apache/sling-org-apache-sling-feature-cpconverter
Re: Sling Content Package to Feature Model Maven Plugin
Posted by Andreas Schaefer <sc...@me.com.INVALID>.
Hi Simone
I ran into a snafu with the Sling Feature Maven Plugin. This plugin is doing a blank check during the initialization phase which is causing headaches for the CP Converter goal.
There are various issues but the most glaring is the fact that when I use placeholders in the FM id like "${project.groupId}” then it will fail to even clean the project with ‘mvn clean’. That we either disable these tests or move them in the respective Mojos?
Cheers - Andy Schaefer
> On Jul 2, 2019, at 10:29 AM, Simone Tripodi <si...@gmail.com> wrote:
>
> Hi Andreas,
> I had a quick overview of your work and you did great - I'd suggest
> you to propose this new MOJO as part of the slingfeature-maven-plugin,
> rather than defining a new one, it will be easier to have it
> integrated.
>
> My 2 cents and keep up the good work!
> All the best,
> ~Simo
>
> http://people.apache.org/~simonetripodi/
> http://www.99soft.org/
>
> On Tue, Jun 18, 2019 at 7:25 AM Andreas Schaefer
> <sc...@me.com.invalid> wrote:
>>
>> Hi
>>
>> I just committed the first draft of the 'Sling Content Package to Feature Model Maven Plugin’ into branch feature/sling-cpconverter-maven-plugin of the sling-whiteboard project.
>>
>> The IT tests should give a rough idea on how to use it and I will incorporate it into the Peregrine CMS project to have a better End-to-End test for this plugin.
>>
>> For now this plugin is intended to generated a side-car FM configuration for an existing Content Package including installing it into the local Maven repo.
>>
>> I am not a crack in writing Maven Plugins so this plugin for sure has it rough edges and so any feedback is appreciated.
>>
>> Cheers - Andy Schaefer
Re: Sling Content Package to Feature Model Maven Plugin
Posted by Simone Tripodi <si...@apache.org>.
Hi Andreas,
that's great, many thanks in advance for your effort!
All the best and chat soon!
~Simo
http://people.apache.org/~simonetripodi/
http://twitter.com/simonetripodi
On Tue, Jul 2, 2019 at 11:23 PM Andreas Schaefer
<sc...@me.com.invalid> wrote:
>
> Hi Simone
>
> Sure, will do so. This plugin is not that big so it should fit in just fine.
>
> - Andy
>
> > On Jul 2, 2019, at 10:29 AM, Simone Tripodi <si...@gmail.com> wrote:
> >
> > Hi Andreas,
> > I had a quick overview of your work and you did great - I'd suggest
> > you to propose this new MOJO as part of the slingfeature-maven-plugin,
> > rather than defining a new one, it will be easier to have it
> > integrated.
> >
> > My 2 cents and keep up the good work!
> > All the best,
> > ~Simo
> >
> > http://people.apache.org/~simonetripodi/
> > http://www.99soft.org/
> >
> > On Tue, Jun 18, 2019 at 7:25 AM Andreas Schaefer
> > <sc...@me.com.invalid> wrote:
> >>
> >> Hi
> >>
> >> I just committed the first draft of the 'Sling Content Package to Feature Model Maven Plugin’ into branch feature/sling-cpconverter-maven-plugin of the sling-whiteboard project.
> >>
> >> The IT tests should give a rough idea on how to use it and I will incorporate it into the Peregrine CMS project to have a better End-to-End test for this plugin.
> >>
> >> For now this plugin is intended to generated a side-car FM configuration for an existing Content Package including installing it into the local Maven repo.
> >>
> >> I am not a crack in writing Maven Plugins so this plugin for sure has it rough edges and so any feedback is appreciated.
> >>
> >> Cheers - Andy Schaefer
>
Re: Sling Content Package to Feature Model Maven Plugin
Posted by Andreas Schaefer <sc...@me.com.INVALID>.
Hi Simone
Sure, will do so. This plugin is not that big so it should fit in just fine.
- Andy
> On Jul 2, 2019, at 10:29 AM, Simone Tripodi <si...@gmail.com> wrote:
>
> Hi Andreas,
> I had a quick overview of your work and you did great - I'd suggest
> you to propose this new MOJO as part of the slingfeature-maven-plugin,
> rather than defining a new one, it will be easier to have it
> integrated.
>
> My 2 cents and keep up the good work!
> All the best,
> ~Simo
>
> http://people.apache.org/~simonetripodi/
> http://www.99soft.org/
>
> On Tue, Jun 18, 2019 at 7:25 AM Andreas Schaefer
> <sc...@me.com.invalid> wrote:
>>
>> Hi
>>
>> I just committed the first draft of the 'Sling Content Package to Feature Model Maven Plugin’ into branch feature/sling-cpconverter-maven-plugin of the sling-whiteboard project.
>>
>> The IT tests should give a rough idea on how to use it and I will incorporate it into the Peregrine CMS project to have a better End-to-End test for this plugin.
>>
>> For now this plugin is intended to generated a side-car FM configuration for an existing Content Package including installing it into the local Maven repo.
>>
>> I am not a crack in writing Maven Plugins so this plugin for sure has it rough edges and so any feedback is appreciated.
>>
>> Cheers - Andy Schaefer
Re: Sling Content Package to Feature Model Maven Plugin
Posted by Simone Tripodi <si...@gmail.com>.
Hi Andreas,
I had a quick overview of your work and you did great - I'd suggest
you to propose this new MOJO as part of the slingfeature-maven-plugin,
rather than defining a new one, it will be easier to have it
integrated.
My 2 cents and keep up the good work!
All the best,
~Simo
http://people.apache.org/~simonetripodi/
http://www.99soft.org/
On Tue, Jun 18, 2019 at 7:25 AM Andreas Schaefer
<sc...@me.com.invalid> wrote:
>
> Hi
>
> I just committed the first draft of the 'Sling Content Package to Feature Model Maven Plugin’ into branch feature/sling-cpconverter-maven-plugin of the sling-whiteboard project.
>
> The IT tests should give a rough idea on how to use it and I will incorporate it into the Peregrine CMS project to have a better End-to-End test for this plugin.
>
> For now this plugin is intended to generated a side-car FM configuration for an existing Content Package including installing it into the local Maven repo.
>
> I am not a crack in writing Maven Plugins so this plugin for sure has it rough edges and so any feedback is appreciated.
>
> Cheers - Andy Schaefer