You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "hainenber (via GitHub)" <gi...@apache.org> on 2026/03/21 04:47:38 UTC
[PR] feat(sec): harden GHA ref by using its SHA ID to prevent accidental usage of compromised actions [superset]
hainenber opened a new pull request, #38782:
URL: https://github.com/apache/superset/pull/38782
feat(sec): harden GHA ref by using its SHA ID to prevent accidental usage of compromised actions
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
A follow-up for PR #38780 to help securing GHA usage and limit potential blast radius for any compromised actions.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(sec): harden GHA ref by using its SHA ID to prevent accidental usage of compromised actions [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #38782:
URL: https://github.com/apache/superset/pull/38782#issuecomment-4102272759
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(sec): harden GHA ref by using its SHA ID to prevent accidental usage of compromised actions [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #38782:
URL: https://github.com/apache/superset/pull/38782#issuecomment-4102274510
## **Sequence Diagram**
This PR hardens CI security by replacing floating GitHub Action version tags with fixed commit SHAs across workflows. The runtime flow stays the same, but each workflow now pulls immutable action revisions to reduce supply chain risk.
```mermaid
sequenceDiagram
participant Developer
participant GitHub
participant WorkflowRunner
participant ActionSource
participant CIJobs
Developer->>GitHub: Trigger workflow run
GitHub->>WorkflowRunner: Load workflow files
WorkflowRunner->>WorkflowRunner: Resolve actions to pinned commit SHAs
WorkflowRunner->>ActionSource: Fetch exact action commits
WorkflowRunner->>CIJobs: Run build test and release steps
CIJobs-->>GitHub: Publish workflow status
```
---
*Generated by [CodeAnt AI](https://codeant.ai)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(sec): harden GHA ref by using its SHA ID to prevent accidental usage of compromised actions [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #38782:
URL: https://github.com/apache/superset/pull/38782#issuecomment-4103499110
**Bito Automatic Review Skipped – PR Already Merged**<br/><br/>Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.<br/>No action is needed if you didn't intend to review it. To get a review, you can type `/review` in a comment and save it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(sec): harden GHA ref by using its SHA ID to prevent accidental usage of compromised actions [superset]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #38782:
URL: https://github.com/apache/superset/pull/38782#discussion_r2969128357
##########
.github/workflows/codeql-analysis.yml:
##########
@@ -31,7 +31,7 @@ jobs:
steps:
- name: Checkout repository
- uses: actions/checkout@v6
+ uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
Review Comment:
While checkout is now pinned, this workflow still references `github/codeql-action` via mutable tags (eg `init@v4` / `analyze@v4`) later in the file. If the intent is to harden action refs across the workflow, those should also be pinned to full commit SHAs (with an inline `# v4` comment) to avoid tag movement.
##########
.github/workflows/dependency-review.yml:
##########
@@ -27,7 +27,7 @@ jobs:
runs-on: ubuntu-24.04
steps:
- name: "Checkout Repository"
- uses: actions/checkout@v6
+ uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
- name: "Dependency Review"
uses: actions/dependency-review-action@v4
Review Comment:
`actions/dependency-review-action` is still referenced via a mutable tag (`@v4`). Since the goal of this PR is to harden workflows by pinning action refs, this step should also be pinned to a full commit SHA (and optionally keep a `# v4` comment) to avoid supply-chain risk from tag movement.
```suggestion
uses: actions/dependency-review-action@781e085422ef0d1a6c8bb0ebb85e9e5c0e7656ca # v4
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(sec): harden GHA ref by using its SHA ID to prevent accidental usage of compromised actions [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber merged PR #38782:
URL: https://github.com/apache/superset/pull/38782
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org