You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/05/05 03:43:02 UTC
[GitHub] [commons-configuration] darkma773r opened a new pull request, #179: Version bumps
darkma773r opened a new pull request, #179:
URL: https://github.com/apache/commons-configuration/pull/179
bumping to commons-parent 53, spring 5.3.19, codeql-action 2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] darkma773r commented on pull request #179: Version bumps
Posted by GitBox <gi...@apache.org>.
darkma773r commented on PR #179:
URL: https://github.com/apache/commons-configuration/pull/179#issuecomment-1118142531
How is this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] asfgit merged pull request #179: Version bumps
Posted by GitBox <gi...@apache.org>.
asfgit merged PR #179:
URL: https://github.com/apache/commons-configuration/pull/179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] kinow commented on pull request #179: Version bumps
Posted by GitBox <gi...@apache.org>.
kinow commented on PR #179:
URL: https://github.com/apache/commons-configuration/pull/179#issuecomment-1118139300
For dependabot updates, I add an entry, squash the commits, and push-force and merge :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] kinow commented on pull request #179: Version bumps
Posted by GitBox <gi...@apache.org>.
kinow commented on PR #179:
URL: https://github.com/apache/commons-configuration/pull/179#issuecomment-1118139132
Not small changes like that one, or fixing imports, simplifying a bit shift operation, etc. Unless you feel like there's a risk that that change could cause a regression.
Updates to dependencies normally go to `changes.xml`, including the Commons Parent, e.g. https://github.com/apache/commons-lang/blob/80889fc45cbfb3da0a916e0fc0d51663bb970c2a/src/changes/changes.xml#L283
But if you have multiple updates in a single PR, you can add a single entry with one update per line, e.g. https://github.com/apache/commons-configuration/blob/69260fa1e9c4f87b1abf1c301825a53a722b6007/src/changes/changes.xml#L103-L107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] darkma773r commented on pull request #179: Version bumps
Posted by GitBox <gi...@apache.org>.
darkma773r commented on PR #179:
URL: https://github.com/apache/commons-configuration/pull/179#issuecomment-1118137591
Ah. I didn't realize we were creating changes entries for that. Should I create an entry for this change as well? https://github.com/apache/commons-configuration/pull/140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] darkma773r commented on pull request #179: Version bumps
Posted by GitBox <gi...@apache.org>.
darkma773r commented on PR #179:
URL: https://github.com/apache/commons-configuration/pull/179#issuecomment-1118145762
Thanks, @kinow!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org