[GitHub] jvrao commented on issue #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load)

[GitBox <gi...@apache.org>]

jvrao commented on issue #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load)
URL: https://github.com/apache/bookkeeper/pull/1088#issuecomment-383799268
 
 
   Alright; go ahead and we can tweak if we see an issue. Simple to change
   later.
   
   On Mon, Apr 23, 2018 at 2:14 PM, Andrey Yegorov <no...@github.com>
   wrote:
   
   > *@dlg99* commented on this pull request.
   > ------------------------------
   >
   > In bookkeeper-server/src/main/java/org/apache/bookkeeper/
   > client/LedgerHandleAdv.java
   > <https://github.com/apache/bookkeeper/pull/1088#discussion_r183539951>:
   >
   > > @@ -211,6 +211,11 @@ public String toString() {
   >              return;
   >          }
   >
   > +        if (!waitForWritable(distributionSchedule.getWriteSet(op.getEntryId()),
   > +                op.getEntryId(), 0, waitForWriteSetMs)) {
   >
   > @jvrao <https://github.com/jvrao> there is an option to set
   > waitTimeoutOnBackpressureMs=0 and get this behavior (immediate
   > fail/ensemble change).
   > I'd argue that in case of spiky traffic it is ok for netty to switch
   > channel in non-writable state and back so to avoid frequent ensemble
   > changes I'd wait a little. Ensemble changes aren't exactly free (takes time
   > + more data in zk)
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/bookkeeper/pull/1088#discussion_r183539951>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/AAChrmoCq0MdvqYaPhUpdZsECYjgF4AHks5trkRKgaJpZM4RyxL8>
   > .
   >
   
   
   
   -- 
   Jvrao
   ---
   First they ignore you, then they laugh at you, then they fight you, then
   you win. - Mahatma Gandhi
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services