You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2021/02/01 11:11:54 UTC

[Impala-ASF-CR] IMPALA-10460: Impala should write normalized paths in Iceberg manifests

Hello Gabor Kaszab, Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16993

to look at the new patch set (#2).

Change subject: IMPALA-10460: Impala should write normalized paths in Iceberg manifests
......................................................................

IMPALA-10460: Impala should write normalized paths in Iceberg manifests

Currently Impala writes double slashes in the paths of datafiles
for non-partitioned Iceberg tables. Unnormalized paths can cause
problems later.

This patch removes the redundant slashes.

Testing:
 * Tested manually by inspecting the manifest files of the
   Iceberg tables. Used both non-partitioned and partitioned tables.

Change-Id: If5ecac78102ed35710dd70a18edc71f6e891e748
---
M be/src/exec/hdfs-table-sink.cc
1 file changed, 8 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/16993/2
-- 
To view, visit http://gerrit.cloudera.org:8080/16993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If5ecac78102ed35710dd70a18edc71f6e891e748
Gerrit-Change-Number: 16993
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>