[I] Three more converters do not recognize OSSIE_SQL_2026: omni, sigma, honeydew [ossie-converters]

["kayemkim (via GitHub)" <gi...@apache.org>]

kayemkim opened a new issue, #22:
URL: https://github.com/apache/ossie-converters/issues/22

   `OSSIE_SQL_2026` is the spec's portable, ANSI-compatible expression language (#439). apache/ossie#442 listed the converters whose dialect fallbacks did not know it, and each was fixed by reading it as an `ANSI_SQL` equivalent (#443, apache/ossie#446, apache/ossie#447, apache/ossie#449, apache/ossie#450). Three converters were not on that list and still only look for `ANSI_SQL`.
   
   - omni: `pick_expression()` in `_common.py` returns `None` for an `OSSIE_SQL_2026`-only expression, so the field or metric is dropped from the export with `no usable ANSI_SQL (or preferred-dialect) expression`.
   - sigma: `ansi_sql_text()` in `expression_utils.py` matches `ANSI_SQL` only. The field is dropped as `EXPRESSION_NOT_TRANSLATABLE`, and the metric is dropped as `CROSS_DATASET_METRIC_DROPPED` on a one-dataset model, because dataset inference never sees the text.
   - honeydew: `_pick_ansi_expression()` in `converter.py` warns `no ANSI_SQL dialect found; using first available` and takes the first array entry. With `[SNOWFLAKE, OSSIE_SQL_2026]` the Snowflake text is exported (`sql: SUM(sales.amount_snowflake_text)`) and comes back from Honeydew labeled `ANSI_SQL`, so a vendor expression ends up under the portable label while a portable one was available.
   
   Reproduced on main eabe562 with the one-dataset, one-metric model from apache/ossie#576, its two `dialect:` tags set to `OSSIE_SQL_2026`: omni and sigma output contain neither `amount` nor `total_amount` where the `ANSI_SQL`-tagged model exports both. None of the three test suites mentions `OSSIE_SQL_2026`.
   
   The fix is the one the earlier PRs used: accept `OSSIE_SQL_2026` wherever `ANSI_SQL` is accepted, ahead of any positional fallback, with a regression test per converter for a field-only and a metric-only `OSSIE_SQL_2026` expression.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org