You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/17 12:17:35 UTC
[GitHub] [spark] MaxGekk opened a new pull request #31576: [SPARK-34451][SQL] Add alternatives for datetime rebasing SQL configs and deprecate legacy configs
MaxGekk opened a new pull request #31576:
URL: https://github.com/apache/spark/pull/31576
### What changes were proposed in this pull request?
Move the datetime rebase SQL configs from the `legacy` namespace by:
1. Renaming of the existing rebase configs like `spark.sql.legacy.parquet.datetimeRebaseModeInRead` -> `spark.sql.parquet.datetimeRebaseModeInRead`.
2. Add the legacy configs as alternatives
3. Deprecate the legacy rebase configs.
### Why are the changes needed?
The rebasing SQL configs like `spark.sql.legacy.parquet.datetimeRebaseModeInRead` can be used not only for migration from previous Spark versions but also to read/write datatime columns saved by other systems/frameworks/libs. So, the configs shouldn't be considered as legacy configs.
### Does this PR introduce _any_ user-facing change?
Should not. Users will see a warning if they still use one of the legacy configs.
### How was this patch tested?
1. Manually checking new configs:
```scala
scala> spark.conf.get("spark.sql.parquet.datetimeRebaseModeInRead")
res0: String = EXCEPTION
scala> spark.conf.set("spark.sql.legacy.parquet.datetimeRebaseModeInRead", "LEGACY")
21/02/17 14:57:10 WARN SQLConf: The SQL config 'spark.sql.legacy.parquet.datetimeRebaseModeInRead' has been deprecated in Spark v3.2 and may be removed in the future. Use 'spark.sql.parquet.datetimeRebaseModeInRead' instead.
scala> spark.conf.get("spark.sql.parquet.datetimeRebaseModeInRead")
res2: String = LEGACY
```
2. By running a datetime rebasing test suite:
```
$ build/sbt "test:testOnly *ParquetRebaseDatetimeV1Suite"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31576: [SPARK-34451][SQL] Add alternatives for datetime rebasing SQL configs and deprecate legacy configs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31576:
URL: https://github.com/apache/spark/pull/31576#issuecomment-780539092
**[Test build #135197 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135197/testReport)** for PR 31576 at commit [`4fd6630`](https://github.com/apache/spark/commit/4fd6630ed1f4b129633bd13d78571fa76a54abaf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31576: [SPARK-34451][SQL] Add alternatives for datetime rebasing SQL configs and deprecate legacy configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31576:
URL: https://github.com/apache/spark/pull/31576#issuecomment-780577941
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39778/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31576: [SPARK-34451][SQL] Add alternatives for datetime rebasing SQL configs and deprecate legacy configs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31576:
URL: https://github.com/apache/spark/pull/31576#issuecomment-780577911
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39778/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31576: [SPARK-34451][SQL] Add alternatives for datetime rebasing SQL configs and deprecate legacy configs
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31576:
URL: https://github.com/apache/spark/pull/31576#issuecomment-780539092
**[Test build #135197 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135197/testReport)** for PR 31576 at commit [`4fd6630`](https://github.com/apache/spark/commit/4fd6630ed1f4b129633bd13d78571fa76a54abaf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31576: [SPARK-34451][SQL] Add alternatives for datetime rebasing SQL configs and deprecate legacy configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31576:
URL: https://github.com/apache/spark/pull/31576#issuecomment-780577941
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39778/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31576: [SPARK-34451][SQL] Add alternatives for datetime rebasing SQL configs and deprecate legacy configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31576:
URL: https://github.com/apache/spark/pull/31576#issuecomment-780737899
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135197/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31576: [SPARK-34451][SQL] Add alternatives for datetime rebasing SQL configs and deprecate legacy configs
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31576:
URL: https://github.com/apache/spark/pull/31576#issuecomment-780578350
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #31576: [SPARK-34451][SQL] Add alternatives for datetime rebasing SQL configs and deprecate legacy configs
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #31576:
URL: https://github.com/apache/spark/pull/31576
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31576: [SPARK-34451][SQL] Add alternatives for datetime rebasing SQL configs and deprecate legacy configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31576:
URL: https://github.com/apache/spark/pull/31576#issuecomment-780737899
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135197/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31576: [SPARK-34451][SQL] Add alternatives for datetime rebasing SQL configs and deprecate legacy configs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31576:
URL: https://github.com/apache/spark/pull/31576#issuecomment-780716224
**[Test build #135197 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135197/testReport)** for PR 31576 at commit [`4fd6630`](https://github.com/apache/spark/commit/4fd6630ed1f4b129633bd13d78571fa76a54abaf).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #31576: [SPARK-34451][SQL] Add alternatives for datetime rebasing SQL configs and deprecate legacy configs
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #31576:
URL: https://github.com/apache/spark/pull/31576#issuecomment-780518305
@cloud-fan @HyukjinKwon @mswit-databricks @tomvanbussel Could you review this PR, please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31576: [SPARK-34451][SQL] Add alternatives for datetime rebasing SQL configs and deprecate legacy configs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31576:
URL: https://github.com/apache/spark/pull/31576#issuecomment-780573061
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39778/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org