You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Sean Lin (JIRA)" <ji...@apache.org> on 2012/08/24 08:57:42 UTC
[jira] [Created] (WICKET-4729) atmosphere example will stop working
if opening the same url in a different tab in the same browser
Sean Lin created WICKET-4729:
--------------------------------
Summary: atmosphere example will stop working if opening the same url in a different tab in the same browser
Key: WICKET-4729
URL: https://issues.apache.org/jira/browse/WICKET-4729
Project: Wicket
Issue Type: Bug
Components: wicket-atmosphere
Affects Versions: 6.0.0-beta3
Reporter: Sean Lin
Assignee: Emond Papegaaij
If the url of a running atmosphere example is copied and then opened in a different tab while the old one left open in the same browser,
i.e. there are two atmosphere examples of the same url opened at the same time in a browser,
one of them will stop working.
I found the cause of this problem is that trackingPages in EventBus is using a BiMap.
If there are different tracking-ids mapping to the same PageKey, one of the map entry will be removed.
The simple solution would be replacing the BiMap with HashMap, but I think there might be reasons why BiMap is used here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Updated] (WICKET-4729) atmosphere example will stop
working if opening the same url in a different tab in the same browser
Posted by Martin Grigorov <mg...@apache.org>.
Hi,
I see it this way:
Wicket.next is 6.0.1, but experimental modules could be versioned as
0.3.1 or 0.4 depending on whether you just fixed something or added
new features. 6.0.1 or 6.1.0 doesn't depend anyhow on the experimental
modules. But I don't see a reason why early adopters to wait for 6.1.0
(that could be released after 6.0.5 for example) for something new in
the experimental modules.
On Tue, Sep 4, 2012 at 9:08 PM, Emond Papegaaij
<em...@gmail.com> wrote:
> What do we do with wicket-experimental modules on the 6.0.1 release?
> As far as my understanding of semantic version goes, 6.0.1 should only
> contain bug fixes, 6.1 will be the next version with new features, but
> still api-compatible. Experimental modules, however, are all versioned
> below 1.0, allowing any change, because semver starts at 1.0. I did
> not break the API, but you could see this as a new feature (multi-tab
> support).
>
> IMHO, 6.1.0 should be the next release, where 6.0.1 will only contain
> some bugfixes. For example, selenium releases a new 2.x.0 every few
> weeks, and only release a 2.x.1 when a critical bug is found. This
> also makes it easier to cope with the experimental modules, because we
> can simply release them with 6.1 and skip 6.0.1.
>
> Best regards,
> Emond
>
> On Tue, Sep 4, 2012 at 8:41 PM, Martin Grigorov (JIRA) <ji...@apache.org> wrote:
>>
>> [ https://issues.apache.org/jira/browse/WICKET-4729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>>
>> Martin Grigorov updated WICKET-4729:
>> ------------------------------------
>>
>> Fix Version/s: (was: 6.1.0)
>> 6.0.1
>>
>>> atmosphere example will stop working if opening the same url in a different tab in the same browser
>>> ---------------------------------------------------------------------------------------------------
>>>
>>> Key: WICKET-4729
>>> URL: https://issues.apache.org/jira/browse/WICKET-4729
>>> Project: Wicket
>>> Issue Type: Bug
>>> Components: wicket-atmosphere
>>> Affects Versions: 6.0.0-beta3
>>> Reporter: Sean Lin
>>> Assignee: Emond Papegaaij
>>> Fix For: 6.0.1
>>>
>>>
>>> If the url of a running atmosphere example is copied and then opened in a different tab while the old one left open in the same browser,
>>> i.e. there are two atmosphere examples of the same url opened at the same time in a browser,
>>> one of them will stop working.
>>> I found the cause of this problem is that trackingPages in EventBus is using a BiMap.
>>> If there are different tracking-ids mapping to the same PageKey, one of the map entry will be removed.
>>> The simple solution would be replacing the BiMap with HashMap, but I think there might be reasons why BiMap is used here.
>>
>> --
>> This message is automatically generated by JIRA.
>> If you think it was sent incorrectly, please contact your JIRA administrators
>> For more information on JIRA, see: http://www.atlassian.com/software/jira
--
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com
Re: [jira] [Updated] (WICKET-4729) atmosphere example will stop
working if opening the same url in a different tab in the same browser
Posted by Emond Papegaaij <em...@gmail.com>.
What do we do with wicket-experimental modules on the 6.0.1 release?
As far as my understanding of semantic version goes, 6.0.1 should only
contain bug fixes, 6.1 will be the next version with new features, but
still api-compatible. Experimental modules, however, are all versioned
below 1.0, allowing any change, because semver starts at 1.0. I did
not break the API, but you could see this as a new feature (multi-tab
support).
IMHO, 6.1.0 should be the next release, where 6.0.1 will only contain
some bugfixes. For example, selenium releases a new 2.x.0 every few
weeks, and only release a 2.x.1 when a critical bug is found. This
also makes it easier to cope with the experimental modules, because we
can simply release them with 6.1 and skip 6.0.1.
Best regards,
Emond
On Tue, Sep 4, 2012 at 8:41 PM, Martin Grigorov (JIRA) <ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/WICKET-4729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Martin Grigorov updated WICKET-4729:
> ------------------------------------
>
> Fix Version/s: (was: 6.1.0)
> 6.0.1
>
>> atmosphere example will stop working if opening the same url in a different tab in the same browser
>> ---------------------------------------------------------------------------------------------------
>>
>> Key: WICKET-4729
>> URL: https://issues.apache.org/jira/browse/WICKET-4729
>> Project: Wicket
>> Issue Type: Bug
>> Components: wicket-atmosphere
>> Affects Versions: 6.0.0-beta3
>> Reporter: Sean Lin
>> Assignee: Emond Papegaaij
>> Fix For: 6.0.1
>>
>>
>> If the url of a running atmosphere example is copied and then opened in a different tab while the old one left open in the same browser,
>> i.e. there are two atmosphere examples of the same url opened at the same time in a browser,
>> one of them will stop working.
>> I found the cause of this problem is that trackingPages in EventBus is using a BiMap.
>> If there are different tracking-ids mapping to the same PageKey, one of the map entry will be removed.
>> The simple solution would be replacing the BiMap with HashMap, but I think there might be reasons why BiMap is used here.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators
> For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4729) atmosphere example will stop
working if opening the same url in a different tab in the same browser
Posted by "Emond Papegaaij (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emond Papegaaij resolved WICKET-4729.
-------------------------------------
Resolution: Fixed
Fix Version/s: 6.1.0
I've reworked the page registration. The BiMap was used to make sure the registration would not grow with every page opened. I've replaced the BiMap with a normal HashMap and added a method to unregister a connection when it is closed.
> atmosphere example will stop working if opening the same url in a different tab in the same browser
> ---------------------------------------------------------------------------------------------------
>
> Key: WICKET-4729
> URL: https://issues.apache.org/jira/browse/WICKET-4729
> Project: Wicket
> Issue Type: Bug
> Components: wicket-atmosphere
> Affects Versions: 6.0.0-beta3
> Reporter: Sean Lin
> Assignee: Emond Papegaaij
> Fix For: 6.1.0
>
>
> If the url of a running atmosphere example is copied and then opened in a different tab while the old one left open in the same browser,
> i.e. there are two atmosphere examples of the same url opened at the same time in a browser,
> one of them will stop working.
> I found the cause of this problem is that trackingPages in EventBus is using a BiMap.
> If there are different tracking-ids mapping to the same PageKey, one of the map entry will be removed.
> The simple solution would be replacing the BiMap with HashMap, but I think there might be reasons why BiMap is used here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4729) atmosphere example will stop working
if opening the same url in a different tab in the same browser
Posted by "Emond Papegaaij (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emond Papegaaij updated WICKET-4729:
------------------------------------
Fix Version/s: (was: 6.0.1)
6.1.0
> atmosphere example will stop working if opening the same url in a different tab in the same browser
> ---------------------------------------------------------------------------------------------------
>
> Key: WICKET-4729
> URL: https://issues.apache.org/jira/browse/WICKET-4729
> Project: Wicket
> Issue Type: Bug
> Components: wicket-atmosphere
> Affects Versions: 6.0.0-beta3
> Reporter: Sean Lin
> Assignee: Emond Papegaaij
> Fix For: 6.1.0
>
>
> If the url of a running atmosphere example is copied and then opened in a different tab while the old one left open in the same browser,
> i.e. there are two atmosphere examples of the same url opened at the same time in a browser,
> one of them will stop working.
> I found the cause of this problem is that trackingPages in EventBus is using a BiMap.
> If there are different tracking-ids mapping to the same PageKey, one of the map entry will be removed.
> The simple solution would be replacing the BiMap with HashMap, but I think there might be reasons why BiMap is used here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4729) atmosphere example will stop working
if opening the same url in a different tab in the same browser
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-4729:
------------------------------------
Fix Version/s: (was: 6.1.0)
6.0.1
> atmosphere example will stop working if opening the same url in a different tab in the same browser
> ---------------------------------------------------------------------------------------------------
>
> Key: WICKET-4729
> URL: https://issues.apache.org/jira/browse/WICKET-4729
> Project: Wicket
> Issue Type: Bug
> Components: wicket-atmosphere
> Affects Versions: 6.0.0-beta3
> Reporter: Sean Lin
> Assignee: Emond Papegaaij
> Fix For: 6.0.1
>
>
> If the url of a running atmosphere example is copied and then opened in a different tab while the old one left open in the same browser,
> i.e. there are two atmosphere examples of the same url opened at the same time in a browser,
> one of them will stop working.
> I found the cause of this problem is that trackingPages in EventBus is using a BiMap.
> If there are different tracking-ids mapping to the same PageKey, one of the map entry will be removed.
> The simple solution would be replacing the BiMap with HashMap, but I think there might be reasons why BiMap is used here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira