[GitHub] [hudi] danny0405 commented on a diff in pull request #7738: [HUDI-5569] Fixing TableFileSystemView to detect early failed commits

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on code in PR #7738:
URL: https://github.com/apache/hudi/pull/7738#discussion_r1084791033


##########
hudi-cli/src/test/java/org/apache/hudi/cli/integ/ITTestRepairsCommand.java:
##########
@@ -262,6 +266,7 @@ public void testDeduplicateNoPartitionWithInserts(HoodieTableType tableType) thr
     connectTableAndReloadMetaClient(tablePath);
     HoodieTableFileSystemView fsView = new HoodieTableFileSystemView(metaClient,
         metaClient.getActiveTimeline().getCommitsTimeline().filterCompletedInstants(),
+        TimelineUtils.getFirstNotCompleted(metaClient.getActiveTimeline().getCommitsTimeline()),

Review Comment:
   Is there any possibility just pass around the `metaClient.getActiveTimeline().getCommitsTimeline()` and resolve the first not completed instant inside the `HoodieTableFileSystemView` constructor. This can avoid many unnecessary changes and the code is cleaner to maintain.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org