You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by andralungu <gi...@git.apache.org> on 2015/04/14 18:26:16 UTC
[GitHub] flink pull request: [FLINK-1871][gelly] Added Spargel to Gelly mig...
GitHub user andralungu opened a pull request:
https://github.com/apache/flink/pull/600
[FLINK-1871][gelly] Added Spargel to Gelly migration guide
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andralungu/flink migrationGuide
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/600.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #600
----
commit 072f595628ca9e05917e82cde81714ac51a6c276
Author: andralungu <lu...@gmail.com>
Date: 2015-04-14T16:22:48Z
[FLINK-1871][gelly] Added Spargel to Gelly migration guide
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1871][gelly] Added Spargel to Gelly mig...
Posted by vasia <gi...@git.apache.org>.
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/600#issuecomment-94175152
I like it that you are using the example to show the migration process, but I think it would also be helpful to add a section with more general guidelines, describing all the differences between Spargel and Gelly.
Among others possibly, we should cover the following:
- Gelly has Vertex and Edge type whereas Spargel operates on Tuple2 and Tuple3
- Spargel has separate methods for edges with values and edges without values. In Gelly, there is only one. Edges without values have a NullValue type.
- Spargel's `runOperation` vs. Gelly's `runVertexCentricIteration`
- Spargel's `OutgoingEdge` type is replaced by `Edge` in Gelly.
- How an iteration is configured in each of the APIs.
- Spargel's record API is completely removed from Gelly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1871][gelly] Added Spargel to Gelly mig...
Posted by andralungu <gi...@git.apache.org>.
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/600#issuecomment-94432522
Hi @vasia ,
The general guidelines were added.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1871][gelly] Added Spargel to Gelly mig...
Posted by vasia <gi...@git.apache.org>.
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/600#issuecomment-98162545
Hey! This looks good, thanks a lot!
I would make some minor changes in the text and merge.
What do you think about making it a separate section instead of a subsection of the vertex-centric iterations? I think it's current place might confuse users who don't know Spargel.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1871][gelly] Added Spargel to Gelly mig...
Posted by andralungu <gi...@git.apache.org>.
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/600#issuecomment-98173050
Hi @vasia !
To me it looked normal, probably because I know Spargel :P
I moved it in a separate section and rebased. Should be fine now :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1871][gelly] Added Spargel to Gelly mig...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/600
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---