You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/11 18:41:03 UTC

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #29730: [SPARK-32845][SS][TESTS] Add sinkParameter to check sink options robustly in DataStreamReaderWriterSuite

dongjoon-hyun edited a comment on pull request #29730:
URL: https://github.com/apache/spark/pull/29730#issuecomment-691253239


   Thank you, @viirya . It's because `stop` calls `queryExecutionThread.join` immediately and notifies the thread, the the thread runs `runStream` -> `override lazy val logicalPlan: LogicalPlan` -> `dataSourceV1.createSource(metadataPath)`. I'll update the PR description.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org