You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by StevenMPhillips <gi...@git.apache.org> on 2016/02/11 01:25:32 UTC

[GitHub] drill pull request: DRILL-4382: Remove dependency on drill-logical...

GitHub user StevenMPhillips opened a pull request:

    https://github.com/apache/drill/pull/373

    DRILL-4382: Remove dependency on drill-logical from vector package

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StevenMPhillips/drill arrow

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/373.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #373
    
----
commit e2be7853aa49467c6db0ab960fe2b11a24ccb84b
Author: Steven Phillips <st...@dremio.com>
Date:   2016-02-05T01:43:17Z

    DRILL-4382: Remove dependency on drill-logical from vector package

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request: DRILL-4382: Remove dependency on drill-logical...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/drill/pull/373


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request: DRILL-4382: Remove dependency on drill-logical...

Posted by jacques-n <gi...@git.apache.org>.
Github user jacques-n commented on the pull request:

    https://github.com/apache/drill/pull/373#issuecomment-183581100
  
    Changes look good to me.  +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request: DRILL-4382: Remove dependency on drill-logical...

Posted by StevenMPhillips <gi...@git.apache.org>.
Github user StevenMPhillips commented on the pull request:

    https://github.com/apache/drill/pull/373#issuecomment-182692303
  
    There are two main changes made in this commit:
    
    1. Removed SchemaPath from MaterializedField. Now, a MaterializedField contains a name (String), and a list of children (MaterializedField). Each MaterializedField instance knows its own name, but has no knowledge of its parents. While making this change, I also got rid of MaterializedField.Key, and made sure that MaterializedField was not used as a Map key anywhere in the code.
    
    2. TransferPair no longer takes a FieldReference, but instead will take a String for the field name.
    
    With those two changes, I was able to remove the dependency on drill-logical.
    
    The rest of the changes in the patch are simply making the rest of the code conform to this new interface.
    
    I should not that this will break external StoragePlugins. They will need to be modified and recompiled.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request: DRILL-4382: Remove dependency on drill-logical...

Posted by jacques-n <gi...@git.apache.org>.
Github user jacques-n commented on the pull request:

    https://github.com/apache/drill/pull/373#issuecomment-182681649
  
    @StevenMPhillips, can you please provide a narrative overview of the nature of these changes?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---