[jira] Commented: (HADOOP-5482) org.apache.hadoop.mapred.lib.db.DBInputformat not working with oracle

["Aaron Kimball (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-5482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727870#action_12727870 ] 

Aaron Kimball commented on HADOOP-5482:
---------------------------------------

Attaching patches for 20-branch and trunk based on the original patch posted here. This rebases the work onto the new API in trunk. Also fixes indentation problems in the initial version of the patch. (The new code was indented at the wrong level.)

Since this adds a db product-specific field, I also used this to set a flag necessary in MySQL, but that's a trivial difference.

I have tested this and verified that it works with Oracle and MySQL locally. No new tests because we don't have an Oracle driver that can be checked in to Hadoop.


> org.apache.hadoop.mapred.lib.db.DBInputformat not working with oracle
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-5482
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5482
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.18.2, 0.18.3, 0.19.0, 0.19.1
>         Environment: Java 1.6, HAdoop0.19.0, Linux..Oracle, 
>            Reporter: evanand
>            Priority: Blocker
>         Attachments: HADOOP-5482.20-branch.patch, HADOOP-5482.patch, HADOOP-5482.trunk.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> org.apache.hadoop.mapred.lib.db.DBInputformat not working with oracle.
> The out of the box implementation of the Hadoop is working properly with mysql/hsqldb, but NOT with oracle.
> Reason is DBInputformat is implemented with mysql/hsqldb specific query constructs like "LIMIT", "OFFSET".
> FIX:
> building a database provider specific logic based on the database providername (which we can get using connection).
> I HAVE ALREADY IMPLEMENTED IT FOR ORACLE...READY TO CHECK_IN CODE

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.