You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2014/02/20 10:00:21 UTC
svn commit: r1570114 - in /tomcat/trunk: build.xml webapps/docs/changelog.xml
Author: markt
Date: Thu Feb 20 09:00:21 2014
New Revision: 1570114
URL: http://svn.apache.org/r1570114
Log:
Simplify patternsets where possible
Avoid pattern sets ending in "/*" as much as possible as they usually result in JARs containing empty packages with the contents of the package in a different JAR
Modified:
tomcat/trunk/build.xml
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/build.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=1570114&r1=1570113&r2=1570114&view=diff
==============================================================================
--- tomcat/trunk/build.xml (original)
+++ tomcat/trunk/build.xml Thu Feb 20 09:00:21 2014
@@ -287,20 +287,18 @@
<!-- ========= Pattern sets used to control content of JAR files ========= -->
<!-- Pattern sets for jar files in standard distributions -->
<patternset id="files.annotations-api">
- <include name="javax/annotation/*" />
- <include name="javax/annotation/security/*" />
- <include name="javax/annotation/sql/*" />
- <include name="javax/ejb/*" />
- <include name="javax/persistence/*" />
- <include name="javax/xml/ws/*" />
+ <include name="javax/annotation/**" />
+ <include name="javax/ejb/**" />
+ <include name="javax/persistence/**" />
+ <include name="javax/xml/ws/**" />
</patternset>
<patternset id="files.servlet-api">
- <include name="javax/servlet/*" />
- <include name="javax/servlet/annotation/*" />
- <include name="javax/servlet/descriptor/*" />
- <include name="javax/servlet/http/*" />
- <include name="javax/servlet/resources/*" />
+ <include name="javax/servlet/*.class" />
+ <include name="javax/servlet/annotation/**" />
+ <include name="javax/servlet/descriptor/**" />
+ <include name="javax/servlet/http/**" />
+ <include name="javax/servlet/resources/**" />
</patternset>
<patternset id="files.jsp-api">
@@ -308,7 +306,7 @@
</patternset>
<patternset id="files.el-api">
- <include name="javax/el/*" />
+ <include name="javax/el/**" />
</patternset>
<patternset id="files.websocket-api">
@@ -335,7 +333,7 @@
</patternset>
<patternset id="files.tomcat-api">
- <include name="org/apache/tomcat/*" />
+ <include name="org/apache/tomcat/*.class" />
</patternset>
<patternset id="files.tomcat-util">
@@ -344,7 +342,7 @@
<include name="org/apache/tomcat/util/file/**" />
<include name="org/apache/tomcat/util/res/**" />
<include name="org/apache/tomcat/util/threads/**" />
- <include name="org/apache/tomcat/util/*" />
+ <include name="org/apache/tomcat/util/*.class" />
</patternset>
<patternset id="files.tomcat-util-scan">
@@ -375,8 +373,7 @@
</patternset>
<patternset id="files.catalina-ant">
- <include name="org/apache/catalina/ant/*" />
- <include name="org/apache/catalina/ant/jmx/*" />
+ <include name="org/apache/catalina/ant/**" />
</patternset>
<patternset id="files.catalina-storeconfig">
@@ -1929,8 +1926,8 @@ Apache Tomcat ${version} native binaries
<include name="org/apache/catalina/startup/DigesterFactory.class" />
<include name="org/apache/catalina/util/SchemaResolver.class" />
<include name="org/apache/catalina/util/StringManager.class" />
- <include name="org/apache/tomcat/util/*" />
- <include name="org/apache/tomcat/util/digester/*" />
+ <include name="org/apache/tomcat/util/*.class" />
+ <include name="org/apache/tomcat/util/digester/**" />
<exclude name="**/package.html" />
<exclude name="**/LocalStrings_*" />
</fileset>
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1570114&r1=1570113&r2=1570114&view=diff
==============================================================================
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu Feb 20 09:00:21 2014
@@ -138,6 +138,9 @@
<bug>56139</bug>: Avoid a web application class loader leak in some unit
tests when running on Windows. (markt)
</fix>
+ <fix>
+ Correct build script to avoid building JARs with empty packages. (markt)
+ </fix>
</changelog>
</subsection>
</section>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org