You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "clayburn (via GitHub)" <gi...@apache.org> on 2023/04/19 14:02:35 UTC

[GitHub] [beam] clayburn opened a new pull request, #26351: Capture build scans on ge.apache.org to benefit from deep build insights

clayburn opened a new pull request, #26351:
URL: https://github.com/apache/beam/pull/26351

   This PR publishes a build scan for every CI build on Jenkins and GitHub Actions and for every local build from an authenticated Apache committer. The build will not fail if publishing fails.
   
   The build scans of the Apache Beam project are published to the Gradle Enterprise instance at https://ge.apache.org/, hosted by the Apache Software Foundation and run in partnership between the ASF and Gradle. This Gradle Enterprise instance has all features and extensions enabled and is freely available for use by the Apache Beam project and all other Apache projects.
   
   Currently, the Apache Beam build is configured to publish build scans to the publicly available https://scans.gradle.com/. This pull request enhances that functionality by instead publishing build scans to https://ge.apache.org/. On this Gradle Enterprise instance, Apache Beam will have access not only to all of the published build scans but other aggregate data features such as:
   
   - Dashboards to view all historical build scans, along with performance trends over time
   - Build failure analytics for enhanced investigation and diagnosis of build failures
   - Test failure analytics to better understand trends and causes around slow, failing, and flaky tests
   
   Very soon, we will follow up this PR with one that connects the Apache Beam build to a remote build cache node solely for the Apache Beam project to further help speed up builds with build caching.
   
   If interested in exploring a fully populated Gradle Enterprise instance, please explore the Maven builds already connected to https://ge.apache.org/, the [Spring project’s instance](https://ge.spring.io/scans?search.relativeStartTime=P28D&search.timeZoneId=Europe/Zurich), or any number of other [OSS projects](https://gradle.com/enterprise-customers/oss-projects/) for which we sponsor instances of Gradle Enterprise.
   
   Please let me know if there are any questions about the value of Gradle Enterprise or the changes in this pull request and I’d be happy to address them.
   
   fixes #26350
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [x] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on a diff in pull request #26351: Capture build scans on ge.apache.org to benefit from deep build insights

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #26351:
URL: https://github.com/apache/beam/pull/26351#discussion_r1198338664


##########
settings.gradle.kts:
##########
@@ -15,34 +15,45 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
+import com.gradle.enterprise.gradleplugin.internal.extension.BuildScanExtensionWithHiddenFeatures
 
 plugins {
-  id("com.gradle.enterprise") version "3.4.1" apply false
+  id("com.gradle.enterprise") version "3.13.2"
+  id("com.gradle.common-custom-user-data-gradle-plugin") version "1.10"
 }
 
 
-// Plugins which require online access should not be enabled when running in offline mode.
-if (!gradle.startParameter.isOffline) {
-  apply(plugin = "com.gradle.enterprise")
-}
-
 // JENKINS_HOME and BUILD_ID set automatically during Jenkins execution
 val isJenkinsBuild = arrayOf("JENKINS_HOME", "BUILD_ID").all { System.getenv(it) != null }
 // GITHUB_REPOSITORY and GITHUB_RUN_ID set automatically during Github Actions run
 val isGithubActionsBuild = arrayOf("GITHUB_REPOSITORY", "GITHUB_RUN_ID").all { System.getenv(it) != null }
-if (isJenkinsBuild || isGithubActionsBuild) {
-  gradleEnterprise {
-    buildScan {
-      // Build Scan enabled and TOS accepted for Jenkins lab build. This does not apply to builds on
-      // non-Jenkins machines. Developers need to separately enable and accept TOS to use build scans.
-      termsOfServiceUrl = "https://gradle.com/terms-of-service"
-      termsOfServiceAgree = "yes"
-      publishAlways()
+val isCi = isJenkinsBuild || isGithubActionsBuild
+
+gradleEnterprise {
+  server = "https://ge.apache.org"
+  allowUntrustedServer = false
+
+  buildScan {
+    capture { isTaskInputFiles = true }
+    isUploadInBackground = !isCi
+    publishAlways()
+    this as BuildScanExtensionWithHiddenFeatures
+    publishIfAuthenticated()
+    obfuscation {
+      ipAddresses { addresses -> addresses.map { "0.0.0.0" } }
     }
   }
 }
 
+buildCache {
+  local {
+    isEnabled = !isCi
+  }
+  remote(gradleEnterprise.buildCache) {
+    isEnabled = false

Review Comment:
   Update: I see
   
   > Very soon, we will follow up this PR with one that connects the Apache Beam build to a remote build cache node solely for the Apache Beam project to further help speed up builds with build caching.
   
   So this is intended. However can we enable it for now to mitigate the worker pressures?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] clayburn commented on a diff in pull request #26351: Capture build scans on ge.apache.org to benefit from deep build insights

Posted by "clayburn (via GitHub)" <gi...@apache.org>.
clayburn commented on code in PR #26351:
URL: https://github.com/apache/beam/pull/26351#discussion_r1191684912


##########
settings.gradle.kts:
##########
@@ -15,34 +15,45 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
+import com.gradle.enterprise.gradleplugin.internal.extension.BuildScanExtensionWithHiddenFeatures
 
 plugins {
-  id("com.gradle.enterprise") version "3.4.1" apply false
+  id("com.gradle.enterprise") version "3.13.2"
+  id("com.gradle.common-custom-user-data-gradle-plugin") version "1.10"
 }
 
 
-// Plugins which require online access should not be enabled when running in offline mode.
-if (!gradle.startParameter.isOffline) {

Review Comment:
   The build scan publishing is implicitly disabled when offline is passed. So the check is not needed and omitting it can simplify your build scripts



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on a diff in pull request #26351: Capture build scans on ge.apache.org to benefit from deep build insights

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #26351:
URL: https://github.com/apache/beam/pull/26351#discussion_r1198336958


##########
settings.gradle.kts:
##########
@@ -15,34 +15,45 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
+import com.gradle.enterprise.gradleplugin.internal.extension.BuildScanExtensionWithHiddenFeatures
 
 plugins {
-  id("com.gradle.enterprise") version "3.4.1" apply false
+  id("com.gradle.enterprise") version "3.13.2"
+  id("com.gradle.common-custom-user-data-gradle-plugin") version "1.10"
 }
 
 
-// Plugins which require online access should not be enabled when running in offline mode.
-if (!gradle.startParameter.isOffline) {
-  apply(plugin = "com.gradle.enterprise")
-}
-
 // JENKINS_HOME and BUILD_ID set automatically during Jenkins execution
 val isJenkinsBuild = arrayOf("JENKINS_HOME", "BUILD_ID").all { System.getenv(it) != null }
 // GITHUB_REPOSITORY and GITHUB_RUN_ID set automatically during Github Actions run
 val isGithubActionsBuild = arrayOf("GITHUB_REPOSITORY", "GITHUB_RUN_ID").all { System.getenv(it) != null }
-if (isJenkinsBuild || isGithubActionsBuild) {
-  gradleEnterprise {
-    buildScan {
-      // Build Scan enabled and TOS accepted for Jenkins lab build. This does not apply to builds on
-      // non-Jenkins machines. Developers need to separately enable and accept TOS to use build scans.
-      termsOfServiceUrl = "https://gradle.com/terms-of-service"
-      termsOfServiceAgree = "yes"
-      publishAlways()
+val isCi = isJenkinsBuild || isGithubActionsBuild
+
+gradleEnterprise {
+  server = "https://ge.apache.org"
+  allowUntrustedServer = false
+
+  buildScan {
+    capture { isTaskInputFiles = true }
+    isUploadInBackground = !isCi
+    publishAlways()
+    this as BuildScanExtensionWithHiddenFeatures
+    publishIfAuthenticated()
+    obfuscation {
+      ipAddresses { addresses -> addresses.map { "0.0.0.0" } }
     }
   }
 }
 
+buildCache {
+  local {
+    isEnabled = !isCi
+  }
+  remote(gradleEnterprise.buildCache) {
+    isEnabled = false

Review Comment:
   I see this is deliberately disabled. What is the reasoning behind this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] runningcode commented on a diff in pull request #26351: Capture build scans on ge.apache.org to benefit from deep build insights

Posted by "runningcode (via GitHub)" <gi...@apache.org>.
runningcode commented on code in PR #26351:
URL: https://github.com/apache/beam/pull/26351#discussion_r1198627537


##########
settings.gradle.kts:
##########
@@ -15,34 +15,45 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
+import com.gradle.enterprise.gradleplugin.internal.extension.BuildScanExtensionWithHiddenFeatures
 
 plugins {
-  id("com.gradle.enterprise") version "3.4.1" apply false
+  id("com.gradle.enterprise") version "3.13.2"
+  id("com.gradle.common-custom-user-data-gradle-plugin") version "1.10"
 }
 
 
-// Plugins which require online access should not be enabled when running in offline mode.
-if (!gradle.startParameter.isOffline) {
-  apply(plugin = "com.gradle.enterprise")
-}
-
 // JENKINS_HOME and BUILD_ID set automatically during Jenkins execution
 val isJenkinsBuild = arrayOf("JENKINS_HOME", "BUILD_ID").all { System.getenv(it) != null }
 // GITHUB_REPOSITORY and GITHUB_RUN_ID set automatically during Github Actions run
 val isGithubActionsBuild = arrayOf("GITHUB_REPOSITORY", "GITHUB_RUN_ID").all { System.getenv(it) != null }
-if (isJenkinsBuild || isGithubActionsBuild) {
-  gradleEnterprise {
-    buildScan {
-      // Build Scan enabled and TOS accepted for Jenkins lab build. This does not apply to builds on
-      // non-Jenkins machines. Developers need to separately enable and accept TOS to use build scans.
-      termsOfServiceUrl = "https://gradle.com/terms-of-service"
-      termsOfServiceAgree = "yes"
-      publishAlways()
+val isCi = isJenkinsBuild || isGithubActionsBuild
+
+gradleEnterprise {
+  server = "https://ge.apache.org"
+  allowUntrustedServer = false
+
+  buildScan {
+    capture { isTaskInputFiles = true }
+    isUploadInBackground = !isCi
+    publishAlways()
+    this as BuildScanExtensionWithHiddenFeatures
+    publishIfAuthenticated()
+    obfuscation {
+      ipAddresses { addresses -> addresses.map { "0.0.0.0" } }
     }
   }
 }
 
+buildCache {
+  local {
+    isEnabled = !isCi
+  }
+  remote(gradleEnterprise.buildCache) {
+    isEnabled = false

Review Comment:
   The issue is actually line 50 which changes the behavior. There was never a remote build cache enabled for this build. I've submitted this PR to fix the issue: https://github.com/apache/beam/pull/26784



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] commented on pull request #26351: Capture build scans on ge.apache.org to benefit from deep build insights

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #26351:
URL: https://github.com/apache/beam/pull/26351#issuecomment-1514845256

   ## [Codecov](https://codecov.io/gh/apache/beam/pull/26351?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#26351](https://codecov.io/gh/apache/beam/pull/26351?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a3cbd21) into [master](https://codecov.io/gh/apache/beam/commit/f2f2fb83a21c231d741008d5fc6fdda7c69bb786?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f2f2fb8) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #26351   +/-   ##
   =======================================
     Coverage   81.06%   81.06%           
   =======================================
     Files         469      469           
     Lines       67164    67164           
   =======================================
     Hits        54446    54446           
     Misses      12718    12718           
   ```
   
   
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on pull request #26351: Capture build scans on ge.apache.org to benefit from deep build insights

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #26351:
URL: https://github.com/apache/beam/pull/26351#issuecomment-1545699914

   Run Java_Spark3_Versions PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] tvalentyn commented on pull request #26351: Capture build scans on ge.apache.org to benefit from deep build insights

Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #26351:
URL: https://github.com/apache/beam/pull/26351#issuecomment-1548296923

   I'm getting:
   
   ```
   FAILURE: Build failed with an exception.
   
   * Where:
   Settings file '/home/valentyn/projects/beam/beam/beam/settings.gradle.kts' line: 20
   
   * What went wrong:
   Plugin [id: 'com.gradle.enterprise', version: '3.13.2'] was not found in any of the following sources:
   
   - Gradle Core Plugins (plugin is not in 'org.gradle' namespace)
   - Plugin Repositories (could not resolve plugin artifact 'com.gradle.enterprise:com.gradle.enterprise.gradle.plugin:3.13.2')
     Searched in the following repositories:
       Gradle Central Plugin Repository
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #26351: Capture build scans on ge.apache.org to benefit from deep build insights

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26351:
URL: https://github.com/apache/beam/pull/26351#issuecomment-1514850348

   Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @Abacn for label build.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] tvalentyn commented on pull request #26351: Capture build scans on ge.apache.org to benefit from deep build insights

Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #26351:
URL: https://github.com/apache/beam/pull/26351#issuecomment-1548426918

   I don't see this error in CI suites though, wondering if some local gradle settings are at fault.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] clayburn commented on a diff in pull request #26351: Capture build scans on ge.apache.org to benefit from deep build insights

Posted by "clayburn (via GitHub)" <gi...@apache.org>.
clayburn commented on code in PR #26351:
URL: https://github.com/apache/beam/pull/26351#discussion_r1191684912


##########
settings.gradle.kts:
##########
@@ -15,34 +15,45 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
+import com.gradle.enterprise.gradleplugin.internal.extension.BuildScanExtensionWithHiddenFeatures
 
 plugins {
-  id("com.gradle.enterprise") version "3.4.1" apply false
+  id("com.gradle.enterprise") version "3.13.2"
+  id("com.gradle.common-custom-user-data-gradle-plugin") version "1.10"
 }
 
 
-// Plugins which require online access should not be enabled when running in offline mode.
-if (!gradle.startParameter.isOffline) {

Review Comment:
   The build scam publishing is implicitly disabled when offline is passed. So the check is not needed and omitting it can simplify your build scripts



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm merged pull request #26351: Capture build scans on ge.apache.org to benefit from deep build insights

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #26351:
URL: https://github.com/apache/beam/pull/26351


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on pull request #26351: Capture build scans on ge.apache.org to benefit from deep build insights

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #26351:
URL: https://github.com/apache/beam/pull/26351#issuecomment-1545700054

   Run Java_GCP_IO_Direct PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] tvalentyn commented on pull request #26351: Capture build scans on ge.apache.org to benefit from deep build insights

Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #26351:
URL: https://github.com/apache/beam/pull/26351#issuecomment-1548424306

   I got it when running `gradlew :sdks:python:container:generatePythonRequirementsAll 
   ` locally. Reverting the PR locally has helped. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #26351: Capture build scans on ge.apache.org to benefit from deep build insights

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26351:
URL: https://github.com/apache/beam/pull/26351#issuecomment-1525585391

   Reminder, please take a look at this pr: @Abacn 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on a diff in pull request #26351: Capture build scans on ge.apache.org to benefit from deep build insights

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #26351:
URL: https://github.com/apache/beam/pull/26351#discussion_r1191626862


##########
settings.gradle.kts:
##########
@@ -15,34 +15,45 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
+import com.gradle.enterprise.gradleplugin.internal.extension.BuildScanExtensionWithHiddenFeatures
 
 plugins {
-  id("com.gradle.enterprise") version "3.4.1" apply false
+  id("com.gradle.enterprise") version "3.13.2"
+  id("com.gradle.common-custom-user-data-gradle-plugin") version "1.10"
 }
 
 
-// Plugins which require online access should not be enabled when running in offline mode.
-if (!gradle.startParameter.isOffline) {

Review Comment:
   Is there a reason we don't need this anymore?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on pull request #26351: Capture build scans on ge.apache.org to benefit from deep build insights

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #26351:
URL: https://github.com/apache/beam/pull/26351#issuecomment-1545699617

   Run Python PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #26351: Capture build scans on ge.apache.org to benefit from deep build insights

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26351:
URL: https://github.com/apache/beam/pull/26351#issuecomment-1553694972

   Hi, this change is very useful, however it seems the new gradle plugin breaks gradle cache -- now all build cannot make use of gradle cache and becomes much slower (see #26776)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #26351: Capture build scans on ge.apache.org to benefit from deep build insights

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26351:
URL: https://github.com/apache/beam/pull/26351#issuecomment-1532920747

   Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @damccorm for label build.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org