You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/09/12 11:46:16 UTC

[GitHub] [netbeans] mbien opened a new pull request #3164: Add Collection/Map.size() > 0 case to isEmpty() refactoring.

mbien opened a new pull request #3164:
URL: https://github.com/apache/netbeans/pull/3164


   SizeEqualsZero perf inspection currently only triggers on size() == 0 and size() != 0. Added the case for size() > 0 which I sometimes encounter in the wild.
    + size() > 0 case is handled like the size() != 0 case in the UI (same check box)
    + updated the warning/fix/desc text accordingly and made it a little bit more dynamic


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien commented on pull request #3164: Add Collection/Map.size() > 0 case to isEmpty() refactoring.

Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3164:
URL: https://github.com/apache/netbeans/pull/3164#issuecomment-917804346


   the failed jdk8 + nbjavac build seems to be unrelated as far as i see.
   https://app.travis-ci.com/github/apache/netbeans/jobs/536851479


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] jlahoda merged pull request #3164: [jackpot] add Collection/Map.size() > 0 case to isEmpty() refactoring.

Posted by GitBox <gi...@apache.org>.
jlahoda merged pull request #3164:
URL: https://github.com/apache/netbeans/pull/3164


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists