You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/19 16:05:56 UTC
[GitHub] [arrow] andygrove commented on a change in pull request #8967: ARROW-10967: [Rust] Make env vars optional
andygrove commented on a change in pull request #8967:
URL: https://github.com/apache/arrow/pull/8967#discussion_r546254073
##########
File path: rust/arrow/src/ipc/reader.rs
##########
@@ -939,12 +939,13 @@ mod tests {
use flate2::read::GzDecoder;
use crate::util::integration_util::*;
- use std::env;
use std::fs::File;
+ use crate::util::test_data_dir::ARROW_TEST_DATA;
+
#[test]
fn read_generated_files() {
- let testdata = env::var("ARROW_TEST_DATA").expect("ARROW_TEST_DATA not defined");
Review comment:
Could you post example output for when an example of test is run and the test data cannot be found? I expected the unwrap does show the detailed error message but just want to be sure since we're reminving these explicit messages here.
##########
File path: rust/arrow/src/ipc/reader.rs
##########
@@ -939,12 +939,13 @@ mod tests {
use flate2::read::GzDecoder;
use crate::util::integration_util::*;
- use std::env;
use std::fs::File;
+ use crate::util::test_data_dir::ARROW_TEST_DATA;
+
#[test]
fn read_generated_files() {
- let testdata = env::var("ARROW_TEST_DATA").expect("ARROW_TEST_DATA not defined");
Review comment:
Could you post example output for when an example of test is run and the test data cannot be found? I expected the unwrap does show the detailed error message but just want to be sure since we're removing these explicit messages here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org