You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/01 21:12:00 UTC

[GitHub] [airflow] dimberman commented on a change in pull request #15137: Adding retries when starting kubernetes pods

dimberman commented on a change in pull request #15137:
URL: https://github.com/apache/airflow/pull/15137#discussion_r605948923



##########
File path: airflow/kubernetes/pod_launcher.py
##########
@@ -98,6 +98,12 @@ def delete_pod(self, pod: V1Pod):
             if e.status != 404:
                 raise
 
+    @tenacity.retry(
+        stop=tenacity.stop_after_attempt(3),
+        wait=tenacity.wait_random_exponential(),
+        reraise=True,
+        retry=tenacity.retry_if_exception_type(ApiException),

Review comment:
       @ashb @SamWheating this might be a good reason to move the pod_launching code into the cncf.kubernetes package. I don't think K8sPodOperators should require dependencies on Airflow for these kinds of fixes.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org