You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Stack <st...@duboce.net> on 2011/07/27 04:17:34 UTC
[DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?
Shall we commit the patch at
https://issues.apache.org/jira/browse/HBASE-3857 for 0.92?
I reviewed it and its high-quality, with lots of new tests, and an
attention to self-migration (which it does) that is heartening.
I'm +1 on committing it now to TRUNK in time for 0.92 before this fat
patch rots our on JIRA.
What you lot think?
St.Ack
Re: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?
Posted by Li Pi <li...@cloudera.com>.
+1 to 0.92 as well.
On Tue, Jul 26, 2011 at 9:59 PM, Dhruba Borthakur <dh...@gmail.com> wrote:
> This increases the efficiency of a hbase cluster tremendously. +1 for
> committing it earlier rather than later.
>
> -dhruba
>
> On Tue, Jul 26, 2011 at 7:29 PM, Andrew Purtell <ap...@apache.org> wrote:
>
>> +1
>>
>> It's a big patch but has seen much more testing than the typical and is of
>> high quality as you mention. Earlier rather than later I'd say. But then
>> let's let 0.92 bake with it sufficiently.
>>
>> Best regards,
>>
>>
>> - Andy
>>
>> Problems worthy of attack prove their worth by hitting back. - Piet Hein
>> (via Tom White)
>>
>>
>> >________________________________
>> >From: Stack <st...@duboce.net>
>> >To: HBase Dev List <de...@hbase.apache.org>
>> >Sent: Tuesday, July 26, 2011 7:17 PM
>> >Subject: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?
>> >
>> >Shall we commit the patch at
>> >https://issues.apache.org/jira/browse/HBASE-3857 for 0.92?
>> >
>> >I reviewed it and its high-quality, with lots of new tests, and an
>> >attention to self-migration (which it does) that is heartening.
>> >
>> >I'm +1 on committing it now to TRUNK in time for 0.92 before this fat
>> >patch rots our on JIRA.
>> >
>> >What you lot think?
>> >
>> >St.Ack
>> >
>> >
>> >
>>
>
>
>
> --
> Connect to me at http://www.facebook.com/dhruba
>
Re: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?
Posted by Dhruba Borthakur <dh...@gmail.com>.
This increases the efficiency of a hbase cluster tremendously. +1 for
committing it earlier rather than later.
-dhruba
On Tue, Jul 26, 2011 at 7:29 PM, Andrew Purtell <ap...@apache.org> wrote:
> +1
>
> It's a big patch but has seen much more testing than the typical and is of
> high quality as you mention. Earlier rather than later I'd say. But then
> let's let 0.92 bake with it sufficiently.
>
> Best regards,
>
>
> - Andy
>
> Problems worthy of attack prove their worth by hitting back. - Piet Hein
> (via Tom White)
>
>
> >________________________________
> >From: Stack <st...@duboce.net>
> >To: HBase Dev List <de...@hbase.apache.org>
> >Sent: Tuesday, July 26, 2011 7:17 PM
> >Subject: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?
> >
> >Shall we commit the patch at
> >https://issues.apache.org/jira/browse/HBASE-3857 for 0.92?
> >
> >I reviewed it and its high-quality, with lots of new tests, and an
> >attention to self-migration (which it does) that is heartening.
> >
> >I'm +1 on committing it now to TRUNK in time for 0.92 before this fat
> >patch rots our on JIRA.
> >
> >What you lot think?
> >
> >St.Ack
> >
> >
> >
>
--
Connect to me at http://www.facebook.com/dhruba
Re: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?
Posted by Andrew Purtell <ap...@apache.org>.
+1
It's a big patch but has seen much more testing than the typical and is of high quality as you mention. Earlier rather than later I'd say. But then let's let 0.92 bake with it sufficiently.
Best regards,
- Andy
Problems worthy of attack prove their worth by hitting back. - Piet Hein (via Tom White)
>________________________________
>From: Stack <st...@duboce.net>
>To: HBase Dev List <de...@hbase.apache.org>
>Sent: Tuesday, July 26, 2011 7:17 PM
>Subject: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?
>
>Shall we commit the patch at
>https://issues.apache.org/jira/browse/HBASE-3857 for 0.92?
>
>I reviewed it and its high-quality, with lots of new tests, and an
>attention to self-migration (which it does) that is heartening.
>
>I'm +1 on committing it now to TRUNK in time for 0.92 before this fat
>patch rots our on JIRA.
>
>What you lot think?
>
>St.Ack
>
>
>
Re: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?
Posted by Todd Lipcon <to...@cloudera.com>.
Review finished. Looks great! Just a few minor touch-ups I mentioned on RB.
On Wed, Jul 27, 2011 at 1:24 PM, Stack <st...@duboce.net> wrote:
> Will apply after Todd finishes his review.
> St.Ack
>
>
> On Wed, Jul 27, 2011 at 1:19 PM, Andrew Purtell <ap...@apache.org>
> wrote:
> > This vote has carried.
> >
> > Best regards,
> >
> >
> > - Andy
> >
> > Problems worthy of attack prove their worth by hitting back. - Piet Hein
> (via Tom White)
> >
> >
> >>________________________________
> >>From: Jean-Daniel Cryans <jd...@apache.org>
> >>To: dev@hbase.apache.org
> >>Sent: Wednesday, July 27, 2011 11:36 AM
> >>Subject: Re: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?
> >>
> >>+1
> >>
> >>On Tue, Jul 26, 2011 at 7:17 PM, Stack <st...@duboce.net> wrote:
> >>> Shall we commit the patch at
> >>> https://issues.apache.org/jira/browse/HBASE-3857 for 0.92?
> >>>
> >>> I reviewed it and its high-quality, with lots of new tests, and an
> >>> attention to self-migration (which it does) that is heartening.
> >>>
> >>> I'm +1 on committing it now to TRUNK in time for 0.92 before this fat
> >>> patch rots our on JIRA.
> >>>
> >>> What you lot think?
> >>>
> >>> St.Ack
> >>>
> >>
> >>
> >>
>
--
Todd Lipcon
Software Engineer, Cloudera
Re: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?
Posted by Stack <st...@duboce.net>.
Will apply after Todd finishes his review.
St.Ack
On Wed, Jul 27, 2011 at 1:19 PM, Andrew Purtell <ap...@apache.org> wrote:
> This vote has carried.
>
> Best regards,
>
>
> - Andy
>
> Problems worthy of attack prove their worth by hitting back. - Piet Hein (via Tom White)
>
>
>>________________________________
>>From: Jean-Daniel Cryans <jd...@apache.org>
>>To: dev@hbase.apache.org
>>Sent: Wednesday, July 27, 2011 11:36 AM
>>Subject: Re: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?
>>
>>+1
>>
>>On Tue, Jul 26, 2011 at 7:17 PM, Stack <st...@duboce.net> wrote:
>>> Shall we commit the patch at
>>> https://issues.apache.org/jira/browse/HBASE-3857 for 0.92?
>>>
>>> I reviewed it and its high-quality, with lots of new tests, and an
>>> attention to self-migration (which it does) that is heartening.
>>>
>>> I'm +1 on committing it now to TRUNK in time for 0.92 before this fat
>>> patch rots our on JIRA.
>>>
>>> What you lot think?
>>>
>>> St.Ack
>>>
>>
>>
>>
Re: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?
Posted by Andrew Purtell <ap...@apache.org>.
This vote has carried.
Best regards,
- Andy
Problems worthy of attack prove their worth by hitting back. - Piet Hein (via Tom White)
>________________________________
>From: Jean-Daniel Cryans <jd...@apache.org>
>To: dev@hbase.apache.org
>Sent: Wednesday, July 27, 2011 11:36 AM
>Subject: Re: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?
>
>+1
>
>On Tue, Jul 26, 2011 at 7:17 PM, Stack <st...@duboce.net> wrote:
>> Shall we commit the patch at
>> https://issues.apache.org/jira/browse/HBASE-3857 for 0.92?
>>
>> I reviewed it and its high-quality, with lots of new tests, and an
>> attention to self-migration (which it does) that is heartening.
>>
>> I'm +1 on committing it now to TRUNK in time for 0.92 before this fat
>> patch rots our on JIRA.
>>
>> What you lot think?
>>
>> St.Ack
>>
>
>
>
Re: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?
Posted by Jean-Daniel Cryans <jd...@apache.org>.
+1
On Tue, Jul 26, 2011 at 7:17 PM, Stack <st...@duboce.net> wrote:
> Shall we commit the patch at
> https://issues.apache.org/jira/browse/HBASE-3857 for 0.92?
>
> I reviewed it and its high-quality, with lots of new tests, and an
> attention to self-migration (which it does) that is heartening.
>
> I'm +1 on committing it now to TRUNK in time for 0.92 before this fat
> patch rots our on JIRA.
>
> What you lot think?
>
> St.Ack
>
RE: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?
Posted by Jonathan Gray <jg...@fb.com>.
+1 for 0.92
> -----Original Message-----
> From: Todd Lipcon [mailto:todd@cloudera.com]
> Sent: Tuesday, July 26, 2011 11:27 PM
> To: dev@hbase.apache.org
> Subject: Re: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?
>
> +1 to the idea of putting it in. I'm going to try to do a code review
> tonight. If we could hold off a day or so to commit I'd appreciate it... but if
> other stuff is blocked on it, go ahead whenever IMO.
>
> On Tue, Jul 26, 2011 at 11:25 PM, Nicolas Spiegelberg
> <ns...@fb.com>wrote:
>
> > +1 for 0.92. This has received a lot of testing and code review internally.
> > We have already found/fixed a number of advanced bugs before even
> > submitting the initial patch. Very high quality.
> >
> > On Jul 26, 2011, at 7:18 PM, "Stack" <st...@duboce.net> wrote:
> >
> > > Shall we commit the patch at
> > > https://issues.apache.org/jira/browse/HBASE-3857 for 0.92?
> > >
> > > I reviewed it and its high-quality, with lots of new tests, and an
> > > attention to self-migration (which it does) that is heartening.
> > >
> > > I'm +1 on committing it now to TRUNK in time for 0.92 before this
> > > fat patch rots our on JIRA.
> > >
> > > What you lot think?
> > >
> > > St.Ack
> >
>
>
>
> --
> Todd Lipcon
> Software Engineer, Cloudera
Re: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?
Posted by Todd Lipcon <to...@cloudera.com>.
+1 to the idea of putting it in. I'm going to try to do a code review
tonight. If we could hold off a day or so to commit I'd appreciate it... but
if other stuff is blocked on it, go ahead whenever IMO.
On Tue, Jul 26, 2011 at 11:25 PM, Nicolas Spiegelberg
<ns...@fb.com>wrote:
> +1 for 0.92. This has received a lot of testing and code review internally.
> We have already found/fixed a number of advanced bugs before even submitting
> the initial patch. Very high quality.
>
> On Jul 26, 2011, at 7:18 PM, "Stack" <st...@duboce.net> wrote:
>
> > Shall we commit the patch at
> > https://issues.apache.org/jira/browse/HBASE-3857 for 0.92?
> >
> > I reviewed it and its high-quality, with lots of new tests, and an
> > attention to self-migration (which it does) that is heartening.
> >
> > I'm +1 on committing it now to TRUNK in time for 0.92 before this fat
> > patch rots our on JIRA.
> >
> > What you lot think?
> >
> > St.Ack
>
--
Todd Lipcon
Software Engineer, Cloudera
Re: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?
Posted by Nicolas Spiegelberg <ns...@fb.com>.
+1 for 0.92. This has received a lot of testing and code review internally. We have already found/fixed a number of advanced bugs before even submitting the initial patch. Very high quality.
On Jul 26, 2011, at 7:18 PM, "Stack" <st...@duboce.net> wrote:
> Shall we commit the patch at
> https://issues.apache.org/jira/browse/HBASE-3857 for 0.92?
>
> I reviewed it and its high-quality, with lots of new tests, and an
> attention to self-migration (which it does) that is heartening.
>
> I'm +1 on committing it now to TRUNK in time for 0.92 before this fat
> patch rots our on JIRA.
>
> What you lot think?
>
> St.Ack
Re: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?
Posted by Ted Yu <yu...@gmail.com>.
I think this should go to 0.92
On Jul 26, 2011, at 7:17 PM, Stack <st...@duboce.net> wrote:
> Shall we commit the patch at
> https://issues.apache.org/jira/browse/HBASE-3857 for 0.92?
>
> I reviewed it and its high-quality, with lots of new tests, and an
> attention to self-migration (which it does) that is heartening.
>
> I'm +1 on committing it now to TRUNK in time for 0.92 before this fat
> patch rots our on JIRA.
>
> What you lot think?
>
> St.Ack