[jira] [Commented] (BOOKKEEPER-426) Make auditor Vote znode store a protobuf containing the host that voted

["Sijie Guo (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527608#comment-13527608 ] 

Sijie Guo commented on BOOKKEEPER-426:
--------------------------------------

{quote}
optional string bookieId = 1;
{quote}

one minor question, is there any special consideration to make 'bookieId' as an optional. is there any cases that bookieId would not be set when auditor votes? if not, I think a required field might be better which enforce the callers to set a bookieId when voting.
                
> Make auditor Vote znode store a protobuf containing the host that voted
> -----------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-426
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-426
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: bookkeeper-auto-recovery
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>            Priority: Minor
>             Fix For: 4.2.0
>
>         Attachments: 0001-BOOKKEEPER-426-Make-auditor-Vote-znode-store-a-proto.patch
>
>
> It currently stores a byte[], its better to use a protobuf in case we need to add more info later or actually use the info for something more than debugging.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira