You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by rsafonseca <gi...@git.apache.org> on 2015/06/07 21:12:52 UTC

[GitHub] cloudstack pull request: Fix findbugs high priority warning

GitHub user rsafonseca opened a pull request:

    https://github.com/apache/cloudstack/pull/362

    Fix findbugs high priority warning

    VmwareStorageManagerImpl.java:1023, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE, Priority: High
    Redundant nullcheck of datastoreVolumePath, which is known to be non-null in com.cloud.hypervisor.vmware.manager.VmwareStorageManagerImpl.getVolumePathInDatastore(DatastoreMO, String)
    
    Assertion is not used in runtime, correct way is throw and handle exception.
    This just gets rid of the warning on the findbugs reports.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rsafonseca/cloudstack findbugs1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/362.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #362
    
----
commit 424b8e0f7a7dc417d09233e8d01d6470db2b4002
Author: Rafael da Fonseca <rs...@gmail.com>
Date:   2015-06-07T09:38:04Z

    Fix findbugs high priority warning
    VmwareStorageManagerImpl.java:1023, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE, Priority: High
    Redundant nullcheck of datastoreVolumePath, which is known to be non-null in com.cloud.hypervisor.vmware.manager.VmwareStorageManagerImpl.getVolumePathInDatastore(DatastoreMO, String)
    
    Assertion is not used in runtime, correct way is throw and handle exception without killing app

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs high priority warning

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/362


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs high priority warning

Posted by DaanHoogland <gi...@git.apache.org>.

Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/362#issuecomment-109897934
  
    accidentally closed anyway, doesn't hurt us immediately.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs high priority warning

Posted by DaanHoogland <gi...@git.apache.org>.

Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/362#issuecomment-109895332
  
    I don't trust findbugs on this one. It seems to me searchFileInSubFolders() can return null.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---