You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/10 21:17:58 UTC
[GitHub] [beam] laysakura opened a new issue, #24100: [Bug]: `Filter.whereFieldName` appears in docs but not available
laysakura opened a new issue, #24100:
URL: https://github.com/apache/beam/issues/24100
### What happened?
### Problem
A doc says:
<https://beam.apache.org/documentation/programming-guide/#filtering-events>
```java
purchases.apply(Filter
.whereFieldName("costCents", c -> c > 100 * 20));
```
Another doc says:
<https://javadoc.io/static/org.apache.beam/beam-sdks-java-core/2.42.0/org/apache/beam/sdk/schemas/transforms/Filter.html>
```java
locations.apply(Filter
.whereFieldName("latitude", lat -> lat < 40.720 && lat > 40.699));
```
But they don't compile due to `Filter.whereFieldName()` is undefined.
### Workaround
I confirmed this worked.
```java
PCollection<Row> nonNegTemperature = temperature.apply(
Filter.<Row>create().whereFieldName("temperature", temp -> (float) temp >= 0));
```
### Solution
- Fix docs?
- Or provide methods from `Filter.Inner` to `Filter`?
### Issue Priority
Priority: 3
### Issue Component
Component: website
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on issue #24100: [Bug]: `Filter.whereFieldName` appears in docs but not available
Posted by GitBox <gi...@apache.org>.
kennknowles commented on issue #24100:
URL: https://github.com/apache/beam/issues/24100#issuecomment-1343261428
thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] laysakura commented on issue #24100: [Bug]: `Filter.whereFieldName` appears in docs but not available
Posted by GitBox <gi...@apache.org>.
laysakura commented on issue #24100:
URL: https://github.com/apache/beam/issues/24100#issuecomment-1341503230
@kennknowles I did: https://github.com/apache/beam/pull/24576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] reuvenlax commented on issue #24100: [Bug]: `Filter.whereFieldName` appears in docs but not available
Posted by GitBox <gi...@apache.org>.
reuvenlax commented on issue #24100:
URL: https://github.com/apache/beam/issues/24100#issuecomment-1320974426
It looks like create() is required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on issue #24100: [Bug]: `Filter.whereFieldName` appears in docs but not available
Posted by GitBox <gi...@apache.org>.
kennknowles commented on issue #24100:
URL: https://github.com/apache/beam/issues/24100#issuecomment-1314299578
@reuvenlax what is the intended method here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on issue #24100: [Bug]: `Filter.whereFieldName` appears in docs but not available
Posted by GitBox <gi...@apache.org>.
kennknowles commented on issue #24100:
URL: https://github.com/apache/beam/issues/24100#issuecomment-1341300264
@laysakura would you be interested in submitting a fix to the docs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] laysakura commented on issue #24100: [Bug]: `Filter.whereFieldName` appears in docs but not available
Posted by GitBox <gi...@apache.org>.
laysakura commented on issue #24100:
URL: https://github.com/apache/beam/issues/24100#issuecomment-1341368173
@kennknowles Yes. I'll try to create a PR later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles closed issue #24100: [Bug]: `Filter.whereFieldName` appears in docs but not available
Posted by GitBox <gi...@apache.org>.
kennknowles closed issue #24100: [Bug]: `Filter.whereFieldName` appears in docs but not available
URL: https://github.com/apache/beam/issues/24100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org