You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2021/05/25 20:51:19 UTC
[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #3048: HADOOP-17711. Fix divide by zero in LoadBalancingKMSClientProvider.
xiaoyuyao commented on a change in pull request #3048:
URL: https://github.com/apache/hadoop/pull/3048#discussion_r639195826
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/LoadBalancingKMSClientProvider.java
##########
@@ -233,6 +233,10 @@ private LoadBalancingKMSClientProvider(URI uri,
}
private int nextIdx() {
+ if (providers.length == 0) {
Review comment:
Thanks @yiyuaner for reporting the issue. Should we check providers.length in constructor as there are many other places assumes providers.length is not 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org