You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "nvazquez (via GitHub)" <gi...@apache.org> on 2023/10/11 03:56:22 UTC
[PR] UI: Fix deploy VM wizard vApp properties [cloudstack]
nvazquez opened a new pull request, #8072:
URL: https://github.com/apache/cloudstack/pull/8072
### Description
This PR fixes the vApp properties values sent as part of the deployVirtualMachine API through the UI
Fixes: #7998
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [x] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Tested with vApps containing properties registered as 'Read settings from OVA' templates on Vmware env
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Fix deploy VM wizard vApp properties [cloudstack]
Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala commented on PR #8072:
URL: https://github.com/apache/cloudstack/pull/8072#issuecomment-1774723421
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Fix deploy VM wizard vApp properties [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #8072:
URL: https://github.com/apache/cloudstack/pull/8072#issuecomment-1757796688
@DaanHoogland I think this is ready but we could double check other vApps sections as well for verification
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Fix deploy VM wizard vApp properties [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8072:
URL: https://github.com/apache/cloudstack/pull/8072#issuecomment-1757015108
@nvazquez , do you need to add to this or can we merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Fix deploy VM wizard vApp properties [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8072:
URL: https://github.com/apache/cloudstack/pull/8072#issuecomment-1756889799
tested ok with a vstream template. in the ui:
call being made:
```
http://localhost:5050/client/api/?zoneid=b97af5af-6dc9-408e-8e5a-d3918591ab95&dynamicscalingenabled=true&iothreadsenabled=false&templateid=d38fd9a5-f30e-42d1-b0a8-740d14aa1f4f&startvm=true&serviceofferingid=5e380a1c-708b-4f48-8aad-c93b8943f387&affinitygroupids=&nicnetworklist[0].nic=12&nicnetworklist[0].network=4430bd0a-978a-43ad-8184-73a680ef6ffc&nicnetworklist[1].nic=13&nicnetworklist[1].network=4430bd0a-978a-43ad-8184-73a680ef6ffc&keypairs=&name=v1&displayname=v1&properties[0].key=A_IPADDR&properties[0].value=10.10.10.1&properties[1].key=B_NETMASK&properties[1].value=255.255.255.0&properties[2].key=C_DEFGATEWAY&properties[2].value=10.10.10.11&properties[3].key=H_HOSTNAME&properties[3].value=vstream&properties[4].key=I_DOMAINNAME&properties[4].value=bla&properties[5].key=E_DNS1&properties[5].value=10.10.10.11&properties[6].key=F_DNS2&properties[6].value=10.10.10.22&properties[7].key=F_NTP1&properties[7].value=10.10.10.11&properties[8].key=G_NTP2&properties[8].value=10.10.10.22&p
roperties[9].key=A_NGENIUS_SERVER_IPV4&properties[9].value=10.10.10.11&properties[10].key=dataDisk&properties[10].value=20&command=deployVirtualMachine&response=json
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Fix deploy VM wizard vApp properties [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr merged PR #8072:
URL: https://github.com/apache/cloudstack/pull/8072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Fix deploy VM wizard vApp properties [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8072:
URL: https://github.com/apache/cloudstack/pull/8072#issuecomment-1774830274
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Fix deploy VM wizard vApp properties [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8072:
URL: https://github.com/apache/cloudstack/pull/8072#issuecomment-1770748303
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8072 (QA-JID-208)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Fix deploy VM wizard vApp properties [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #8072:
URL: https://github.com/apache/cloudstack/pull/8072#issuecomment-1770723826
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Fix deploy VM wizard vApp properties [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #8072:
URL: https://github.com/apache/cloudstack/pull/8072#issuecomment-1756810236
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8072?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#8072](https://app.codecov.io/gh/apache/cloudstack/pull/8072?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (def62d4) into [4.18](https://app.codecov.io/gh/apache/cloudstack/commit/864a195868036b367ccf22ec1f26b08ce7d931d7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (864a195) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 4.18 #8072 +/- ##
=========================================
Coverage 13.06% 13.06%
Complexity 9108 9108
=========================================
Files 2720 2720
Lines 257537 257537
Branches 40156 40156
=========================================
Hits 33658 33658
Misses 219649 219649
Partials 4230 4230
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Fix deploy VM wizard vApp properties [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8072:
URL: https://github.com/apache/cloudstack/pull/8072#issuecomment-1770726490
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Fix deploy VM wizard vApp properties [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8072:
URL: https://github.com/apache/cloudstack/pull/8072#issuecomment-1774725015
@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Fix deploy VM wizard vApp properties [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #8072:
URL: https://github.com/apache/cloudstack/pull/8072#issuecomment-1776563020
Option to add a new network can be a separate improvement as it has been the same behaviour even before this PR @kiranchavala cc @nvazquez
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org